From: Palmer Dabbelt <palmer@dabbelt.com>
To: joseph@codesourcery.com
Cc: libc-alpha@sourceware.org, patches@groups.riscv.org,
Andrew Waterman <andrew@sifive.com>,
dj@redhat.com, Darius Rad <darius@bluespec.com>
Subject: Re: [PATCH v6 01/16] sysdeps/init_array: Add PREINIT_FUNCTION to crti.S
Date: Fri, 26 Jan 2018 17:54:00 -0000 [thread overview]
Message-ID: <mhng-800b989a-94b7-46f7-bf74-2659a818eecb@palmer-si-x1c4> (raw)
In-Reply-To: <alpine.DEB.2.20.1801261219170.14878@digraph.polyomino.org.uk>
On Fri, 26 Jan 2018 04:21:41 PST (-0800), joseph@codesourcery.com wrote:
> On Thu, 25 Jan 2018, Palmer Dabbelt wrote:
>
>> This uses '.section .init_array,"aw"', while pt-crti.S contains
>> '.section .init_array,"a",%init_array'. I think we should include the
>> '%init_array' section type as well. Additionally, I'm not sure about
>
> I think you should follow pt-crti.S exactly - using "a" not "aw" and using
> %init_array. You also need to remove the #include of <sys/asm.h>, which
> is an architecture-specific header not available on most architectures.
> OK with those changes.
>
>> the % vs @ distinction -- the gas documentation suggests that only ARM
>> uses '%', so maybe this generic directory should use '@' instead? FWIW,
>> the RISC-V assembler appears to accept '%init_array' and '@init_array'.
>
> % is valid everywhere. @ is valid everywhere except platforms, such as
> ARM, that use @ as a comment character that can start comments in the
> middle of a line. So in such an architecture-independent file, % is
> appropriate.
Thanks. I've added a sort of TODO patch locally to my binutils tree to try to
remind me to clarify the documentation.
next prev parent reply other threads:[~2018-01-26 17:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 5:44 RISC-V glibc port, v6 Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 10/16] RISC-V: Atomic and Locking Routines Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 01/16] sysdeps/init_array: Add PREINIT_FUNCTION to crti.S Palmer Dabbelt
2018-01-26 12:56 ` Joseph Myers
2018-01-26 17:54 ` Palmer Dabbelt [this message]
2018-01-26 5:45 ` [PATCH v6 15/16] RISC-V: Build Infastructure Palmer Dabbelt
2018-01-26 13:15 ` Joseph Myers
2018-01-26 18:00 ` Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 04/16] Add documentation for __riscv_flush_icache Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 16/16] Add RISC-V to build-many-glibcs.py Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 12/16] RISC-V: Linux ABI Palmer Dabbelt
2018-01-26 13:12 ` Joseph Myers
2018-01-26 18:05 ` Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 06/16] RISC-V: Startup and Dynamic Loading Code Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 02/16] Skeleton documentation for the RISC-V port Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 11/16] RISC-V: Linux Syscall Interface Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 03/16] Add RISC-V entries to config.h.in Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 05/16] RISC-V: ABI Implementation Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 14/16] RISC-V: Add ABI Lists Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 08/16] RISC-V: Generic <math.h> and soft-fp Routines Palmer Dabbelt
2018-01-26 13:10 ` Joseph Myers
2018-01-26 18:03 ` Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 07/16] RISC-V: Thread-Local Storage Support Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 09/16] RISC-V: Hard Float Support Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 13/16] RISC-V: Linux Startup and Dynamic Loading Code Palmer Dabbelt
2018-01-26 12:49 ` RISC-V glibc port, v6 Joseph Myers
2018-01-26 17:51 ` Palmer Dabbelt
2018-01-26 15:05 ` Joseph Myers
2018-01-26 18:18 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-800b989a-94b7-46f7-bf74-2659a818eecb@palmer-si-x1c4 \
--to=palmer@dabbelt.com \
--cc=andrew@sifive.com \
--cc=darius@bluespec.com \
--cc=dj@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=patches@groups.riscv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).