From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-89632-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 115054 invoked by alias); 26 Jan 2018 17:07:47 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 115038 invoked by uid 89); 26 Jan 2018 17:07:46 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=
X-HELO: mail-pf0-f173.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id
         :mime-version:content-transfer-encoding;
        bh=NOQyIBEm5zgQHV6NaHV3ChUs0RMvxasLxbX0gbyDi+U=;
        b=AKAw0f20ELuvBjHLcv32Y0arbG8i+O7CdCqIRYyF5VQTjMmoO+4WBVKkxff2rNvZBS
         S2H2+9L7eqF/Px4KPy4Ue96fEkQPGBgpkPWKhGbG5kT/TFxBBw2LlO4HE8e6YjDwAJWc
         FBDikl5hxF7FctTXcaupRM4Yk2j07bFqAzDX8pkgoJdyL+uuIeyl/j+HjglnxPC7ea3H
         fL8W0fScR8oQAMYVmp6Zw8WSDA9GZ7O8g9umruYmPXbk4XO47pyZQxc9nnQ7ICRMKCxe
         oddliwxh1ZF1JHTSL9ut7qoC5uRjMve9ZrkYXwwgENiBlWkStg1IUE8XK3VUl81RWrEO
         5Vcg==
X-Gm-Message-State: AKwxytdSael8EGx86r2fFy4qX4JHl7JpqS/2KLMpi96yw86JRkgt8nUD
	W1aZa5a8VpOtDbJSfrmuOPxfIPI1KCY=
X-Google-Smtp-Source: AH8x225ngY1lw5l7UsfZsvF7eWP9rChHqrxKJ9pG/kA+ZSgMYqL7wdwOpGNyFcaJ9RUtkWHhI0iBqQ==
X-Received: by 2002:a17:902:7083:: with SMTP id z3-v6mr15004206plk.404.1516986463520;
        Fri, 26 Jan 2018 09:07:43 -0800 (PST)
Date: Fri, 26 Jan 2018 17:54:00 -0000
X-Google-Original-Date: Fri, 26 Jan 2018 09:03:39 PST (-0800)
Subject:     Re: [PATCH v6 01/16] sysdeps/init_array: Add PREINIT_FUNCTION to crti.S
In-Reply-To: <alpine.DEB.2.20.1801261219170.14878@digraph.polyomino.org.uk>
CC: libc-alpha@sourceware.org, patches@groups.riscv.org,
  Andrew Waterman <andrew@sifive.com>, dj@redhat.com, Darius Rad <darius@bluespec.com>
From: Palmer Dabbelt <palmer@dabbelt.com>
To: joseph@codesourcery.com
Message-ID: <mhng-800b989a-94b7-46f7-bf74-2659a818eecb@palmer-si-x1c4>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SW-Source: 2018-01/txt/msg00936.txt.bz2

On Fri, 26 Jan 2018 04:21:41 PST (-0800), joseph@codesourcery.com wrote:
> On Thu, 25 Jan 2018, Palmer Dabbelt wrote:
>
>> This uses '.section .init_array,"aw"', while pt-crti.S contains
>> '.section .init_array,"a",%init_array'.  I think we should include the
>> '%init_array' section type as well.  Additionally, I'm not sure about
>
> I think you should follow pt-crti.S exactly - using "a" not "aw" and using
> %init_array.  You also need to remove the #include of <sys/asm.h>, which
> is an architecture-specific header not available on most architectures.
> OK with those changes.
>
>> the % vs @ distinction -- the gas documentation suggests that only ARM
>> uses '%', so maybe this generic directory should use '@' instead?  FWIW,
>> the RISC-V assembler appears to accept '%init_array' and '@init_array'.
>
> % is valid everywhere.  @ is valid everywhere except platforms, such as
> ARM, that use @ as a comment character that can start comments in the
> middle of a line.  So in such an architecture-independent file, % is
> appropriate.

Thanks.  I've added a sort of TODO patch locally to my binutils tree to try to 
remind me to clarify the documentation.