From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67766 invoked by alias); 25 Dec 2017 20:20:57 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 67756 invoked by uid 89); 25 Dec 2017 20:20:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=no version=3.3.2 spammy=Hx-languages-length:1263, HContent-Transfer-Encoding:8bit X-HELO: mail-pf0-f176.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=1hEn5vmBbj4fFBApgpSlDzXqGDs248Mq+AzOQoBFvRg=; b=jqgLhjxHHybMbjVyAVy2HMf7+BFiQ2hNeW9if+bYCMcqxMNN4cqkSsiAsettLK8Epw +GZDQpc0I77Yao2GgmFh5MWzIB1fRDAtep+jL9i3UM5VXt2/ARQSovqa6gOsGGdFqoIp eMLfaOAteyjGQwg/8ESAo9rTj/EHUZY4CPjD8RvT6mxaTHFhmiL4+B81BuL3SkL4noXS 1PwFlpdUEfFCS5d0t3lG3eVKQcNuvr+0bD1181nYXmZ4la8Rb5Ab5JT5tlNcLsaej+AZ iddyRH0luaW9f2isbjmPl2NeFb3pJ48IDB7vdX5Ocp8rwH8BhQBEl65/7YH2QAD0Ke4v 7kyQ== X-Gm-Message-State: AKGB3mJ332WSOsao9djdb2De4f57C9sOryAiKPhYBiugi1hXj1olzEHw IbMfzBf0uQigTUj/2cShY+ngM3rIMYY= X-Google-Smtp-Source: ACJfBovRR8KCqyZX36uUzjEHa3v7LW2cGN1BnzJ+yMuqWZUaKVPkSrDVbWLQxwQn4kttkvFrS6dccw== X-Received: by 10.99.60.23 with SMTP id j23mr20375834pga.256.1514233253813; Mon, 25 Dec 2017 12:20:53 -0800 (PST) Date: Mon, 25 Dec 2017 20:20:00 -0000 X-Google-Original-Date: Mon, 25 Dec 2017 12:20:34 PST (-0800) Subject: Re: RISC-V glibc port v2 In-Reply-To: CC: libc-alpha@sourceware.org, Andrew Waterman , Darius Rad , dj@redhat.com From: Palmer Dabbelt To: joseph@codesourcery.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2017-12/txt/msg00892.txt.bz2 On Wed, 20 Dec 2017 09:40:43 PST (-0800), joseph@codesourcery.com wrote: > On Tue, 19 Dec 2017, Palmer Dabbelt wrote: > >> Thanks to everyone who has helped review the patch set! I believe we've gone >> through all the feedback from the first patch set. Sorry if we've missed >> anything, but at this point I think it'd be best to re-submit it -- it's been a >> long time since the previous patch set. > > Apart from the points I've mentioned in comments on individual patches, as > previously noted you need a c++-types.data ABI baseline or baselines. And > as previously noted a bits/environments.h header may be appropriate though > not required. And you're missing libm-test-ulps / libm-test-ulps-name > files. I don't think we need a bits/environments.h right now, but I think we will need one if we're going to support ILP32 on RV64I-based systems. If I understand correctly, it's OK to add this file when we add the new ABI? I'll add the libm-test-ulps* files, I just need to get the native test suite running to generate them. Thanks for all the help! My plan is to go through the remaining feedback on the v2 and then submit a v3 when build-many-glibcs.py passes all the tests, which I think I'm pretty close to having done.