From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id E2A443858D37 for ; Mon, 18 Mar 2024 15:41:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2A443858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E2A443858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1031 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710776480; cv=none; b=PMsv//iNYi3IU5lGAAO1tNqOf8ipYUIqJbsyTUIIBivDalJmzCXX3Njo2U2xdwM4kg+2NCtQiPYzg1W8rGgsxQ0vrsNF/6QePqmPhEOisVDZqWvC+Li1amIA4CLN73M1xgeR0kqDba4Ky1hLevJrtp5sLgZSGL8Wu2dVzjUpHR4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710776480; c=relaxed/simple; bh=zA/zdQUtZENQhdTYVQ8LtA3WyS+wilEa8zujzMYou80=; h=DKIM-Signature:Date:Subject:From:To:Message-ID:Mime-Version; b=RcOvo+wYM3L2Is7oycE+g94lFCKVS808qO7b6brYFFanVft+vQjd3bKSpqU0CCKiFm5IUbnIfcfKaJBsvuK4uZwNMQYSw1g5SX8+jLDP07a61Jp2FOMYvsHUQMz7Z4hIpuhDPZxSgBMG2guKldyOHw7Etz1K5SpS4fb2lkjwr64= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-29f9bffaa3bso807040a91.0 for ; Mon, 18 Mar 2024 08:41:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1710776477; x=1711381277; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=k+Qmgp7nqUCo3vAG+MZdyDRc9ZNNybJNHutMAYEu+gU=; b=2uH1jdkxfD/+bytMvmYq2Owy+qgnabQuE+1pnqO+EfTNzj8BWr50DOS4ZU7oIq+PfL ++X46gwHH/Sl/ZHNrCqBg5Lv4sTm48PnzUJFD6UtKt4nibVbjW699mCK6XpLe5eNL1YU YzU2OFHQV334Kwlk0uAe3vtqvGk9Q7pi3sqP55NFbhJ73Quw3CEOtkCUfvQoVHBtzENm DB0iFWyGFCbmYmPbKat3efPLdEaDGDNt8mM3rzK7J9GCDMl7AN6yrc5lBd+dRe44jXA8 a6Z3UZipTlAahsel9gxDnh8ivtOOVPI/W7s6pqdL5o2zGTYHB3hktNBtIbRdyYpFcMP1 khgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710776477; x=1711381277; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k+Qmgp7nqUCo3vAG+MZdyDRc9ZNNybJNHutMAYEu+gU=; b=O7fOwQD6EM3ReEU+RIsiBmx2lrPMBZ/QG/108vLY4bdTngubCL8Zx2HjlPCybF1H38 tPtjcq27hmKxUyVluYSSA6CwYXgFyCdSnaJnXtDzKLSKy6Iyh/Vf6LBksumPajEw9NC/ 1UzxLRbqvRwZxcYgLS4I1tJn6hMp0iw6oB8SMxzroA3W3ONkFTlyQuVrW4nb2MIlIPWB xzRA8lJviyPVu5n92jHcacJ/qcuTcZj/f6h3yjvCu1ICmUBQhUM8GmpAyk7Sej7rhmJm 3FGqzAs526wRIGAlg9Co9cYnNMdwK0pFzbqOOMg6Lu9VSe2Oz6xd7rx9v/5JCn0YhA7+ Wkeg== X-Forwarded-Encrypted: i=1; AJvYcCU7FcsaAAyie8X7SR4LV0j3bWtSkD3G8Ue5J8dWTHNXygenG8hQKbbrH1991MSyi2HE39O28YAnz/SZlHCMOCv+CGwo1Ndr/rW8 X-Gm-Message-State: AOJu0YyQxRZXyG04nXl8gs5YcU2qTYJkeNlbGT9Vy2WtlaskyPXVqB08 +d9XJmhzjMTWl5F7NUJhHj2Pz/7JQYWX3d7ukfJwnomS81lKEenpvzM4rCslDs8= X-Google-Smtp-Source: AGHT+IFhAi97G0k/jp00cH5Js1BItii+b4IJwuWk5vcPmepAc0v334fKSn48DSvk1sutkHMbKFee9g== X-Received: by 2002:a17:90b:215:b0:29b:347f:23ea with SMTP id fy21-20020a17090b021500b0029b347f23eamr9218630pjb.3.1710776476582; Mon, 18 Mar 2024 08:41:16 -0700 (PDT) Received: from localhost ([192.184.165.199]) by smtp.gmail.com with ESMTPSA id s65-20020a17090a2f4700b0029dd7b52d1bsm8670484pjd.56.2024.03.18.08.41.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 08:41:15 -0700 (PDT) Date: Mon, 18 Mar 2024 08:41:15 -0700 (PDT) X-Google-Original-Date: Mon, 18 Mar 2024 08:41:14 PDT (-0700) Subject: Re: [PATCH v2] build-many-glibcs.py: Avoid loading user/system configurations In-Reply-To: CC: simon.chopin@canonical.com, Carlos O'Donell , libc-alpha@sourceware.org, schwab@suse.de From: Palmer Dabbelt To: arjun@redhat.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 18 Mar 2024 06:31:00 PDT (-0700), arjun@redhat.com wrote: >> I have commit verification turned on by default, which trips up pulling >> when there is a non-signed commit at HEAD. There's likely a whole class >> of similar configuration issues that could crop up, so this just ignores >> user configuration files entirely. >> >> Signed-off-by: Palmer Dabbelt > > Looks like this unconditionally sets these environment variables? I'm > wondering if this limits other use cases like e.g., users who set > these environment variables and expect those values to be used during > build-many-glibcs (for whatever reason)? Ya, I was kind of worried about that too. I've also got a bunch of insteadOf lines in my configs, and while I don't know of anything that would trip up build-many-glibcs if they disappeared I wouldn't be surprised if someone else had a setup that did. That's why the v1 went the other way and just tried to override the signature verification for the pulls. IIRC there's some sort of global git config to override per-repo-path settings, maybe the right answer is to just do that for whatever test paths I have? >> --- >> This has been pretty lightly tested, but it seems to not be breaking >> anything on my end. >> >> Changes since v1 <20240112185846.24483-1-palmer@rivosinc.com/>: >> * Ignore the git configs rather than passing "--no-verify-signatures" to >> "git pull" commands. >> --- >> scripts/build-many-glibcs.py | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py >> index cc30dd5862..0d06ca1ba4 100755 >> --- a/scripts/build-many-glibcs.py >> +++ b/scripts/build-many-glibcs.py >> @@ -1976,8 +1976,15 @@ def check_for_required_tools(): >> if count_old_tools > 0 or count_missing_tools > 0: >> exit (1); >> >> +def setup_env_vars(): >> + # Prevents git from loading configuration files, to avoid tripping over >> + # user settings like --verify-signatures. >> + os.environ["GIT_CONFIG_GLOBAL"] = "/dev/null" >> + os.environ["GIT_CONFIG_NOSYSTEM"] = "1" >> + >> def main(argv): >> """The main entry point.""" >> + setup_env_vars(); >> check_for_required_tools(); >> parser = get_parser() >> opts = parser.parse_args(argv) >> -- >> 2.43.0 >>