From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35181 invoked by alias); 23 Dec 2017 22:01:17 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 35165 invoked by uid 89); 23 Dec 2017 22:01:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mail-pl0-f52.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=LIbSPlYSNreSXwce1BH/fSxqZvHSMa/zxzfTeqQKXUQ=; b=n6x0DIcbxxFYcyPfakcjtBYs7PuCtrKa5HYCzMRtRWXDlpwisn2vukzmgjUqcX/YBA IivMmoaF8mCgLa2liZ1wLBFZvin2IqOcC1X/pJ3uXVkUTOAbqXrKzToG0jLDWDDw0+3K vQbisUP9NHjZ1v2pXvXlt/I0lnKYlLbvbvnsrWuT7N4IZoGDWYX7HhyE4ISJRWrijtT+ 5E8+W5AfOYEOV5F2lq/nciJ0IBCtpqQD6BpPvy83vXV8FlblDRwSs+T+1PnA0sTvbH04 KsmsqXgIX8TP8N1Bqwk/QpoVW6q2SFmreLYHGVMzMQvN6FvWUt6SdUEUUZQc5wcOVGD1 7XQg== X-Gm-Message-State: AKGB3mKeNh+14RqWewF1Vb4opl87M/YCvOEFOgEu8AYaV8JjOGlhflYy 2zw3s4gfBD0jeMJTzrXH1TQ5u3G8ArU= X-Google-Smtp-Source: ACJfBosXem83m/siF+bZQXu4AWzUspIWHqb48NMh78ZDBX0KFXJ2anNgF8PkC8Tly38da/CJK3HjQg== X-Received: by 10.84.224.131 with SMTP id s3mr18216343plj.39.1514066474182; Sat, 23 Dec 2017 14:01:14 -0800 (PST) Date: Sat, 23 Dec 2017 22:01:00 -0000 X-Google-Original-Date: Sat, 23 Dec 2017 14:00:27 PST (-0800) Subject: Re: [PATCH v2 05/15] RISC-V: Generic Routines In-Reply-To: CC: libc-alpha@sourceware.org, Andrew Waterman , Darius Rad , dj@redhat.com From: Palmer Dabbelt To: joseph@codesourcery.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2017-12/txt/msg00877.txt.bz2 On Wed, 20 Dec 2017 08:48:15 PST (-0800), joseph@codesourcery.com wrote: > On Tue, 19 Dec 2017, Palmer Dabbelt wrote: > >> This patch contains fast versions of the various routines from string.h >> that have been implemented for RISC-V. Since RISC-V doesn't define any >> specific performance characteristics they're not optimized for any >> particular microarchitecture, but are designed to be generally good. > > I would again suggest deferring adding such functions, especially the C > ones, and instead helping with updating / reviewing RTH's optimized > generic string functions posted a while back, and only adding > RISC-V-specific ones if there is some clear reason RISC-V needs something > non-generic for optimal performance. Yes, that makes sense -- I think I forgot last time because they hadn't gone in yet. We'll just use the generic ones for now, I'll add it to my TODO list to make sure they're generating good code for RISC-V.