From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 9116E3849AF1 for ; Wed, 17 Apr 2024 12:26:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9116E3849AF1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9116E3849AF1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713356793; cv=none; b=brlBsT4kFr+eqghh65Cdri5mMtx5jvjmJz2Lk4ty5CJOmton/1azgJ1uZsRjNogewxykMb1FSSaEoWjkcbrXCppXluWwqkByivLf9KG/5lEqday3iOm7+HzhuwGM90fGCjw67AByZvHn2YRfZCZQ+F1Ffc9kNdgvvixFBwTqfO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713356793; c=relaxed/simple; bh=TKvVP8t3QEPXcOXyRBGAk/fLxrfEKeaP3ym8M+/5zJM=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=rySzgyHEwKW0llgl79OazuRDATwODrS+dUN3IvmIcpAYbDfRqTi3Np7HBH5hLUpfmUukoounM1xtUuQJRgUt/CA7wX2FWllhffu34DRuVDm5KSpTT14JZIWWheRiy5IycH2NwS5E5A9jDAEyEju80Lx67D7xHo3ZKwTd253S/8Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from hawking.nue2.suse.org (unknown [10.168.4.11]) by smtp-out2.suse.de (Postfix) with ESMTP id A5C8F208B1; Wed, 17 Apr 2024 12:26:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713356790; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1+pzH+Ztjaq8QAI4vDHVeceRGqzQNB23CrRyFoq8dgw=; b=kB/oUPFT/p5E6qzaPXQFDAvjct4wXo8ZNyhA6l3It3CjGC1688p78/o3a/JATXx2uO0+Fw fmQi7/OfV4iviaFBOGV3BxleYtLxRhl0zWCSgUkynCCYgs1wWMgeGUpB94E1wd4rJCXttK IxDPXG6uL8I6nNQsv1wDwlfCEKMIlLE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713356790; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1+pzH+Ztjaq8QAI4vDHVeceRGqzQNB23CrRyFoq8dgw=; b=WA7sgjYAs/+TnFlXUEztT+7E1JC4LEdTJ5gytWAn/hdM8sdzupuaYGNiYpU7T1gpBhjKiN 4FnXfofBzHLtD1Ag== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713356790; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1+pzH+Ztjaq8QAI4vDHVeceRGqzQNB23CrRyFoq8dgw=; b=kB/oUPFT/p5E6qzaPXQFDAvjct4wXo8ZNyhA6l3It3CjGC1688p78/o3a/JATXx2uO0+Fw fmQi7/OfV4iviaFBOGV3BxleYtLxRhl0zWCSgUkynCCYgs1wWMgeGUpB94E1wd4rJCXttK IxDPXG6uL8I6nNQsv1wDwlfCEKMIlLE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713356790; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1+pzH+Ztjaq8QAI4vDHVeceRGqzQNB23CrRyFoq8dgw=; b=WA7sgjYAs/+TnFlXUEztT+7E1JC4LEdTJ5gytWAn/hdM8sdzupuaYGNiYpU7T1gpBhjKiN 4FnXfofBzHLtD1Ag== Received: by hawking.nue2.suse.org (Postfix, from userid 17005) id 8AFB74A04B2; Wed, 17 Apr 2024 14:26:00 +0200 (CEST) From: Andreas Schwab To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Paul Eggert , Bruno Haible Subject: Re: [PATCH v5] posix: Sync tempname with gnulib In-Reply-To: <20240410122009.784038-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Wed, 10 Apr 2024 09:20:09 -0300") References: <20240410122009.784038-1-adhemerval.zanella@linaro.org> X-Yow: Are we on STRIKE yet? Date: Wed, 17 Apr 2024 14:26:00 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Level: X-Spamd-Result: default: False [-4.19 / 50.00]; BAYES_HAM(-2.99)[99.97%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.998]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email] X-Spam-Score: -4.19 X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Apr 10 2024, Adhemerval Zanella wrote: > @@ -299,25 +246,23 @@ try_tempname_len (char *tmpl, int suffixlen, void *args, > { > if (vdigits == 0) > { > - do > - { > - v = random_bits (v, use_getrandom); > - use_getrandom = true; > - } > - while (unfair_min <= v); v >= unfair_min > + /* Worry about bias only if the bits are high quality. */ > + while (random_bits (&v, v) && biased_min <= v) v >= biased_min -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."