From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id C7B323858C52 for ; Mon, 18 Mar 2024 09:23:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7B323858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C7B323858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710753843; cv=none; b=UpR8Aa235pgdIlSguqeiBD3an4zqoCBMRzVqDF4teVD6kGT87IGYmH/xUfwp/LBjymkAXgg0+Jn/+yMh8aKXFr2f4XTE64HO2W8enwYH2eopx2MGElL+WNbAYtcLfAa0onrlPR8iE6mpRxd3JGh19yefba/yo476dpw7kbF/eI8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710753843; c=relaxed/simple; bh=c1khx1eeHXSRkiJQoQR34z9qrKSwd0Q1k9r8pIrHQAc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=f5SBoUCWIqQRE82NBca9neR04xPAdp5VY7w13dY3M9wxoCKkdS3Lw0xsGB5RzvX2ZEd87LIBQ2nrL24moE7HA6DNfAik80KyM1Y+8ujgowCz/rNabqUOX94z9UW+rA8hZClGZc5Qn3fEtXI6CpLhHyfAqjjtnOiFWRgrpy7EIVQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from hawking.nue2.suse.org (unknown [10.168.4.11]) by smtp-out2.suse.de (Postfix) with ESMTP id C07895C323; Mon, 18 Mar 2024 09:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710753837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v9QkBXhaYrz2lGFBuL+eiCwTTl8x1nDMoqKyk8rLK/o=; b=RMrnEwcRfePHOJFfq2zDKsFdSpdLcQzsSmHRIUlGso8XOsS3kMfiIcASW2kXx93VoJ3C3i u0zIC1CctZT8XOwleMQJVJEeMI8usRZmztCrBtuEsxA8QD6/tAodrK8Fg6nxcFNRhsshMv 1Dt3MqcNLR9uzs/Kpv0LZYrgyuqBH/U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710753837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v9QkBXhaYrz2lGFBuL+eiCwTTl8x1nDMoqKyk8rLK/o=; b=La7CksCMLUT9DLWfDQaekF7CF3XbKVkXA5c0KrtWW8KFYNcuEXX6yWeT6sFsM582H15Id5 8jjcnDLZxzwFcLBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710753837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v9QkBXhaYrz2lGFBuL+eiCwTTl8x1nDMoqKyk8rLK/o=; b=RMrnEwcRfePHOJFfq2zDKsFdSpdLcQzsSmHRIUlGso8XOsS3kMfiIcASW2kXx93VoJ3C3i u0zIC1CctZT8XOwleMQJVJEeMI8usRZmztCrBtuEsxA8QD6/tAodrK8Fg6nxcFNRhsshMv 1Dt3MqcNLR9uzs/Kpv0LZYrgyuqBH/U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710753837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v9QkBXhaYrz2lGFBuL+eiCwTTl8x1nDMoqKyk8rLK/o=; b=La7CksCMLUT9DLWfDQaekF7CF3XbKVkXA5c0KrtWW8KFYNcuEXX6yWeT6sFsM582H15Id5 8jjcnDLZxzwFcLBA== Received: by hawking.nue2.suse.org (Postfix, from userid 17005) id A36BE4AAC2D; Mon, 18 Mar 2024 10:23:27 +0100 (CET) From: Andreas Schwab To: Job Snijders Cc: Florian Weimer , libc-alpha@sourceware.org Subject: Re: [PATCH] resolv: add IPv6 support to inet_net_pton() In-Reply-To: (Job Snijders's message of "Mon, 18 Mar 2024 08:59:49 +0000") References: <87zfuxcdjd.fsf@oldenburg.str.redhat.com> X-Yow: Yow! STYROFOAM.. Date: Mon, 18 Mar 2024 10:23:27 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 5.82 X-Spamd-Result: default: False [5.82 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_SHORT(3.00)[1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_SPAM_LONG(3.50)[1.000]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-0.58)[81.37%] Authentication-Results: smtp-out2.suse.de; none X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mär 18 2024, Job Snijders wrote: > + __set_errno (0); > + lbits = strtol(sep, &ep, 10); > + if (sep[0] == '\0' || *ep != '\0') { > + __set_errno (ENOENT); > + return (-1); > + } > + if ((errno == ERANGE && (lbits == LONG_MAX || lbits == LONG_MIN)) > + || (lbits > 128 || lbits < 0)) { > + __set_errno (EMSGSIZE); > + return (-1); I think the first half of the error check is redundant since we only accept values in the range [0,128] anyway. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."