From: Andreas Schwab <schwab@suse.de>
To: Peter Edwards <peadar@arista.com>
Cc: Peter Edwards via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: Avoid pointer-arithmetic underflow in ldconfig
Date: Mon, 04 Sep 2023 18:26:43 +0200 [thread overview]
Message-ID: <mvm1qfd3nwc.fsf@suse.de> (raw)
In-Reply-To: <CAO1X7jspq9Nq-2uyJvYZak_04v4vUspnM1YsETbFEvwUUCgzCw@mail.gmail.com> (Peter Edwards's message of "Mon, 4 Sep 2023 16:34:01 +0100")
On Sep 04 2023, Peter Edwards wrote:
>>
>>
>>
>> > I guess intptr_t might be a better option than uintptr_t?
>>
>> I think a wide enough signed type would be better, since the result is
>> supposed to be signed.
>>
> That's what I'm suggesting, right?
If you are suggesting to change loadoff to intptr_t, then it's ok. But
we should not mix ptrdiff_t with intptr_t.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2023-09-04 16:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 10:54 Peter Edwards
2023-09-04 11:18 ` Andreas Schwab
2023-09-04 12:32 ` Peter Edwards
2023-09-04 14:27 ` Andreas Schwab
2023-09-04 15:34 ` Peter Edwards
2023-09-04 16:26 ` Andreas Schwab [this message]
2023-09-04 16:28 ` Peter Edwards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm1qfd3nwc.fsf@suse.de \
--to=schwab@suse.de \
--cc=libc-alpha@sourceware.org \
--cc=peadar@arista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).