From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Qiol=EU=suse.de=schwab@sourceware.org>
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
	by sourceware.org (Postfix) with ESMTPS id 154193858425
	for <libc-alpha@sourceware.org>; Mon,  4 Sep 2023 16:26:45 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 154193858425
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
	by smtp-out2.suse.de (Postfix) with ESMTP id 50C901F74B;
	Mon,  4 Sep 2023 16:26:44 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1693844804; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=pILI5ZXSqrcNLnkdQ7h1dbFsMrmBZ/cqYTF6UdOOpgY=;
	b=CJanDPesDofWiDEnGDVRaY85PTqfkBuTSZmVmBO46rHzQWoxKSUY1p93LpDWswLmLA2rXD
	WF1HQhL4zLLbSvAP31k7QgoVq22RvsWHkKHSqwyhEf3QSXq6cI9aC1wMwx/wAPOR1MaHUa
	gH+V7UN1S6Aj6FjajPL9lJLwe18t5X0=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1693844804;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=pILI5ZXSqrcNLnkdQ7h1dbFsMrmBZ/cqYTF6UdOOpgY=;
	b=k2Fi7+eQxlXiJj22135brBcBMH4IMnL5pR4hpmVjG4PZ+ZIfDbFVHtQrg6D8Z7CQXu+dXi
	mS5V/dQGKZV+fEDg==
Received: from hawking.nue2.suse.org (unknown [10.168.4.11])
	by relay2.suse.de (Postfix) with ESMTP id 4AE122C142;
	Mon,  4 Sep 2023 16:26:44 +0000 (UTC)
Received: by hawking.nue2.suse.org (Postfix, from userid 17005)
	id ECAFA4A04C0; Mon,  4 Sep 2023 18:26:43 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: Peter Edwards <peadar@arista.com>
Cc: Peter Edwards via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: Avoid pointer-arithmetic underflow in ldconfig
In-Reply-To: <CAO1X7jspq9Nq-2uyJvYZak_04v4vUspnM1YsETbFEvwUUCgzCw@mail.gmail.com>
	(Peter Edwards's message of "Mon, 4 Sep 2023 16:34:01 +0100")
References: <20230904105427.283848-1-peadar@arista.com>
	<mvmmsy22nly.fsf@suse.de>
	<CAO1X7jtwruthdm5ZgTBAeOptpQYT8OHgn7-tTNaRc+AqtA2UGQ@mail.gmail.com>
	<mvmedje2ev6.fsf@suse.de>
	<CAO1X7jspq9Nq-2uyJvYZak_04v4vUspnM1YsETbFEvwUUCgzCw@mail.gmail.com>
X-Yow: Okay, BARBRA STREISAND, I recognize you now!!  Also EFREM ZIMBALIST,
 JUNIOR!!  And BEAUMONT NEWHALL!!  Everybody into th' BATHROOM!
Date: Mon, 04 Sep 2023 18:26:43 +0200
Message-ID: <mvm1qfd3nwc.fsf@suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Sep 04 2023, Peter Edwards wrote:

>>
>>
>>
>> > I guess intptr_t might be a better option than uintptr_t?
>>
>> I think a wide enough signed type would be better, since the result is
>> supposed to be signed.
>>
> That's what I'm suggesting, right?

If you are suggesting to change loadoff to intptr_t, then it's ok.  But
we should not mix ptrdiff_t with intptr_t.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."