From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 366353858D3C for ; Tue, 21 Feb 2023 09:17:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 366353858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 6F64B34691; Tue, 21 Feb 2023 09:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676971051; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jZ1VRFf/605njHv/lKVwDL725iV58NbRoVxllWJ3R4I=; b=WbtMM1FxSGDuXSsiDAUVpLKExUbsQ2BU4KFw26bBHEVkgWpGtHhcRLiUSDaeWK1kTfU1xz UKJZohb0ipkVqwk9Db6m+dTuHvf52sxqpt9ChtZny/g4slyo3zuuPCJ1k/YFCrWWgWMK2t aa/ZxqUbT/bIbtRCZ4vHTlddUPLv2uE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676971051; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jZ1VRFf/605njHv/lKVwDL725iV58NbRoVxllWJ3R4I=; b=7XyR9I7+DbgQoKBV2X0ege7x6WwkCh2GK3nV8itOfWvAHSsU2tUzJuStNQeLRB/R2GzeFn Gjd0WYl231wV2oAg== Received: from hawking.suse.de (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id 5EDAB2C141; Tue, 21 Feb 2023 09:17:31 +0000 (UTC) Received: by hawking.suse.de (Postfix, from userid 17005) id C3871442EF6; Tue, 21 Feb 2023 10:17:30 +0100 (CET) From: Andreas Schwab To: Joseph Myers Cc: Adhemerval Zanella Netto , Subject: Re: [v3] C2x scanf binary constant handling References: <59ac1e6d-6698-6056-df8c-cf4f83848d@codesourcery.com> X-Yow: I need "RONDO". Date: Tue, 21 Feb 2023 10:17:30 +0100 In-Reply-To: <59ac1e6d-6698-6056-df8c-cf4f83848d@codesourcery.com> (Joseph Myers's message of "Tue, 21 Feb 2023 02:20:52 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Feb 21 2023, Joseph Myers wrote: >> Should we also add test for ill formatted inputs? > > I don't think there's a real difference here between "ill formatted > for %i with the new feature" and "ill formatted for %i without the > feature" - some new cases become accepted with the feature, but > nothing is an ill formatted input that wasn't already. Perhaps add a test with a lone "0b" which at least triggers a new code path. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."