From: Andreas Schwab <schwab@suse.de>
To: fweimer@redhat.com (Florian Weimer)
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] iconv: Avoid writable data and relocations in IBM charsets
Date: Wed, 26 Oct 2016 09:23:00 -0000 [thread overview]
Message-ID: <mvm60ofjwgc.fsf@hawking.suse.de> (raw)
In-Reply-To: <20161026091538.A7628439942E0@oldenburg.str.redhat.com> (Florian Weimer's message of "Wed, 26 Oct 2016 11:15:38 +0200")
On Okt 26 2016, fweimer@redhat.com (Florian Weimer) wrote:
> The IBM930, IBM933, IBM935 and IBM939 converters defined lookup
> tables which were not constant. They also contained an
> unnecessary pointer indirection.
>
> 2016-10-26 Florian Weimer <fweimer@redhat.com>
>
> * iconvdata/ibm930.h (__ucs4_to_ibm930sb): Switch from writable
> array of string pointers to constant array of two-character
> arrays.
> * iconvdata/ibm933.h (__ucs4_to_ibm933sb): Likewise.
> * iconvdata/ibm935.h (__ucs4_to_ibm935sb): Likewise.
> * iconvdata/ibm939.h (__ucs4_to_ibm939sb): Likewise.
>
> diff --git a/iconvdata/ibm930.h b/iconvdata/ibm930.h
> index 1afda56..1f2d87d 100644
> --- a/iconvdata/ibm930.h
> +++ b/iconvdata/ibm930.h
> @@ -1499,7 +1499,7 @@ static const struct gap __ucs4_to_ibm930sb_idx[] =
> { .start = 0xffff, .end = 0xffff, .idx = 0 }
> };
>
> -static const char * __ucs4_to_ibm930sb[] =
> +static const char __ucs4_to_ibm930sb[][2] =
I think you can even make that [1].
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2016-10-26 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 9:15 Florian Weimer
2016-10-26 9:23 ` Andreas Schwab [this message]
2016-10-26 10:00 ` Florian Weimer
2016-10-26 10:21 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm60ofjwgc.fsf@hawking.suse.de \
--to=schwab@suse.de \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).