From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id E64733861863 for ; Thu, 15 Feb 2024 12:25:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E64733861863 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E64733861863 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707999929; cv=none; b=qPCm/+sCkSbUP0Vb8WRncgPyN7G+SGwFCiTcgirdtso7xET/T10A19mcpu5Dy43dsaxLCOXpsptbiw0K0MjjuCQvpmMa8r76hzpG4x6HDzAXFBUbPxiClW8MDUUCji2xc1xKbVz8aSE+9swMbqqEwz/ZwQCtAAGJLdb3yBYRUWg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707999929; c=relaxed/simple; bh=52snzObnkvl+Ra76EvMHCeMf6VeGBXHDefnSeuX6rr4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=GGf0BUCcXEQ0gx2K5ua2Fs4iMMyoqZS/ORjFXYP4yzPQBcK/3o1weBDL9Du/uq3Zl5iegxf0Yg2CxbfiFosoM1lhD4UfjV3n4KNjwwJuiJdmyy2CvvDPx45M+2Dt0F2bRDisg5Y6cf4pqAKCsRic4bH2QUD/mwl3VvnG07h3T9A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from hawking.nue2.suse.org (unknown [10.168.4.11]) by smtp-out1.suse.de (Postfix) with ESMTP id CFDE521F69; Thu, 15 Feb 2024 12:25:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707999925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1lQKOeG9WiOWeU0SZwhl0tnhVZBeFmKwBmijy9JYKSc=; b=NvxLlRAyYNpAxwHPMh1vNbqpna886Jx/BaU4a8DPulAOOcKs1xjiQpHHmBgVHW69iJfaQK PkA44hVutpn1XJiXQ4covH41mudTEjXbMWUaHbuwTT0zTv8MfwuDxLBrIexAOiRdhS0krM 7s8A40aN2xkhI7GvwUmrl2ag9s8160I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707999925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1lQKOeG9WiOWeU0SZwhl0tnhVZBeFmKwBmijy9JYKSc=; b=vyOGSeQB9KT7ahOxhiU5jJ9X8d7he0vwURWEbPQiQ5g0N2yPTJP9Y98BGEiCOY21qbE7km F+RPLCw4a5loAmAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707999925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1lQKOeG9WiOWeU0SZwhl0tnhVZBeFmKwBmijy9JYKSc=; b=NvxLlRAyYNpAxwHPMh1vNbqpna886Jx/BaU4a8DPulAOOcKs1xjiQpHHmBgVHW69iJfaQK PkA44hVutpn1XJiXQ4covH41mudTEjXbMWUaHbuwTT0zTv8MfwuDxLBrIexAOiRdhS0krM 7s8A40aN2xkhI7GvwUmrl2ag9s8160I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707999925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1lQKOeG9WiOWeU0SZwhl0tnhVZBeFmKwBmijy9JYKSc=; b=vyOGSeQB9KT7ahOxhiU5jJ9X8d7he0vwURWEbPQiQ5g0N2yPTJP9Y98BGEiCOY21qbE7km F+RPLCw4a5loAmAw== Received: by hawking.nue2.suse.org (Postfix, from userid 17005) id BDAED4A04EC; Thu, 15 Feb 2024 13:25:25 +0100 (CET) From: Andreas Schwab To: "H.J. Lu" Cc: libc-alpha@sourceware.org, carlos@redhat.com Subject: Re: [PATCH] sort-makefile-lines.py: Allow '_' in name and "^# name" In-Reply-To: <20240215112719.392617-1-hjl.tools@gmail.com> (H. J. Lu's message of "Thu, 15 Feb 2024 03:27:19 -0800") References: <20240215112719.392617-1-hjl.tools@gmail.com> X-Yow: I decided to be JOHN TRAVOLTA instead!! Date: Thu, 15 Feb 2024 13:25:25 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -3.46 X-Spamd-Result: default: False [-3.46 / 50.00]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-2.16)[95.96%] X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Feb 15 2024, H.J. Lu wrote: > @@ -139,8 +139,8 @@ def sort_makefile_lines(): > # must have the matching comment name for it to be valid. > rangemarks = [] > for sm in startmarks: > - # Look for things like " # var" to end the sorted list. > - reg = r'^ # ' + sm[1] + r'$' > + # Look for things like "^ *# var" to end the sorted list. > + reg = r'^ *# ' + sm[1] + r'$' The comment is a bit confusing now, as the actual regexp is "^ *# var$". I think the old comment still fits. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."