From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=bqom=EX=suse.de=schwab@sourceware.org>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c])
	by sourceware.org (Postfix) with ESMTPS id 31B303858D35
	for <libc-alpha@sourceware.org>; Thu,  7 Sep 2023 07:28:41 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 31B303858D35
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
	by smtp-out1.suse.de (Postfix) with ESMTP id A989721865;
	Thu,  7 Sep 2023 07:28:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1694071719; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=WgEwGLvLTy5QImhZPQP5MkH6So/xivwGPCHo12ABo9A=;
	b=uf9ZdEtkD+2p3Jk0EpeOkv8GNCb8+UhGFF+3cswkuFxzs7oU28lfmbXdxiEbVD/b0mYScU
	SMSMrgQzVRIyl6kp60wCklrLHLHRarx4V9+8WVpQn6THDkur3g66w8j0x8+dy7UaLznMvI
	kMJbHUSnR7LpL5BplqRRMzmyOsVRGqw=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1694071719;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=WgEwGLvLTy5QImhZPQP5MkH6So/xivwGPCHo12ABo9A=;
	b=aYT3kxLkuodekrvBOR80NCEStA1BRS53Iv7tQn/6fF+AjWZgcaC9VGtHJf+maLuS1XVp8B
	HR0FTML8mDyyxFAA==
Received: from hawking.nue2.suse.org (unknown [10.168.4.11])
	by relay2.suse.de (Postfix) with ESMTP id A196E2C143;
	Thu,  7 Sep 2023 07:28:39 +0000 (UTC)
Received: by hawking.nue2.suse.org (Postfix, from userid 17005)
	id 96DCA4A03BC; Thu,  7 Sep 2023 09:28:39 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3] io: Fix record locking contants for powerpc64 with
 __USE_FILE_OFFSET64
In-Reply-To: <20230831191541.2271412-1-aurelien@aurel32.net> (Aurelien Jarno's
	message of "Thu, 31 Aug 2023 21:15:42 +0200")
References: <20230831191541.2271412-1-aurelien@aurel32.net>
X-Yow: Being a BALD HERO is almost as FESTIVE as a TATTOOED KNOCKWURST.
Date: Thu, 07 Sep 2023 09:28:39 +0200
Message-ID: <mvm7cp2zbko.fsf@suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Aug 31 2023, Aurelien Jarno wrote:

> Commit 5f828ff824e3b7cd1 ("io: Fix F_GETLK, F_SETLK, and F_SETLKW for
> powerpc64") fixed an issue with the value of the lock constants on
> powerpc64 when not using __USE_FILE_OFFSET64, but it ended-up also
> changing the value when using __USE_FILE_OFFSET64 causing an API change.
>
> Fix that by also checking that define, restoring the pre
> 4d0fe291aed3a476a commit values:
>
> Default values:
> - F_GETLK: 5
> - F_SETLK: 6
> - F_SETLKW: 7
>
> With -D_FILE_OFFSET_BITS=64:
> - F_GETLK: 12
> - F_SETLK: 13
> - F_SETLKW: 14
>
> At the same time, it has been noticed that there was no test for io lock
> with __USE_FILE_OFFSET64, so just add one.

Ok.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."