From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-72592-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 17207 invoked by alias); 17 Aug 2016 14:51:54 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 17195 invoked by uid 89); 17 Aug 2016 14:51:53 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=labs
X-HELO: mx2.suse.de
From: Andreas Schwab <schwab@suse.de>
To: Torvald Riegel <triegel@redhat.com>
Cc: GLIBC Devel <libc-alpha@sourceware.org>,  Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH Fix incorrect double-checked locking related to _res_hconf.initialized. [BZ #20477]
References: <1471436135.14544.96.camel@localhost.localdomain>
X-Yow: Leona, I want to CONFESS things to you..
 I want to WRAP you in a SCARLET ROBE trimmed with POLYVINYL CHLORIDE..
 I want to EMPTY your ASHTRAYS...
Date: Wed, 17 Aug 2016 14:51:00 -0000
In-Reply-To: <1471436135.14544.96.camel@localhost.localdomain> (Torvald
	Riegel's message of "Wed, 17 Aug 2016 14:15:35 +0200")
Message-ID: <mvm7fbfphxf.fsf@hawking.suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2016-08/txt/msg00510.txt.bz2

On Aug 17 2016, Torvald Riegel <triegel@redhat.com> wrote:

> diff --git a/resolv/res_hconf.h b/resolv/res_hconf.h
> index b97734d..a3d23f3 100644
> --- a/resolv/res_hconf.h
> +++ b/resolv/res_hconf.h
> @@ -25,6 +25,15 @@
>  
>  struct hconf
>  {
> +  /* We keep the INITIALIZED member only for backwards compatibility.  New
> +     code should just call _res_hconf_init unconditionally.  For this field
> +     to be used safely, users must ensure that either (1) a call to
> +     _res_hconf_init happens-before any load from INITIALIZED, or (2) an
                               ^
> +     assignment of zero to INITIALIZED happens-before any load from it, and
                                                 ^

Those hyphens look wrong.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."