From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <schwab@suse.de>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by sourceware.org (Postfix) with ESMTPS id 64E6F3857C62
 for <libc-alpha@sourceware.org>; Mon,  5 Oct 2020 08:08:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 64E6F3857C62
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=schwab@suse.de
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
 by mx2.suse.de (Postfix) with ESMTP id 6E4A0AF7F;
 Mon,  5 Oct 2020 08:08:25 +0000 (UTC)
From: Andreas Schwab <schwab@suse.de>
To: Lukasz Majewski <lukma@denx.de>
Cc: Joseph Myers <joseph@codesourcery.com>,  Paul Eggert
 <eggert@cs.ucla.edu>,  Adhemerval Zanella <adhemerval.zanella@linaro.org>,
 Alistair Francis <alistair23@gmail.com>,  Arnd Bergmann <arnd@arndb.de>,
 Alistair Francis <alistair.francis@wdc.com>,  GNU C Library
 <libc-alpha@sourceware.org>,  Florian Weimer <fweimer@redhat.com>,  Carlos
 O'Donell <carlos@redhat.com>,  Stepan Golosunov <stepan@golosunov.pp.ru>,
 Zack Weinberg <zackw@panix.com>,  Jeff Law <law@redhat.com>
Subject: Re: [RFC PATCH v1] y2038: nptl: Convert
 pthread_mutex_{clock|timed}lock to support 64 bit
References: <20200923122502.28172-1-lukma@denx.de>
X-Yow: HUGH BEAUMONT died in 1982!!
Date: Mon, 05 Oct 2020 10:08:24 +0200
In-Reply-To: <20200923122502.28172-1-lukma@denx.de> (Lukasz Majewski's message
 of "Wed, 23 Sep 2020 14:25:02 +0200")
Message-ID: <mvma6x1858n.fsf@suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Oct 2020 08:08:28 -0000

On Sep 23 2020, Lukasz Majewski wrote:

> +  int err = INTERNAL_SYSCALL_CALL (futex_time64, futex, __lll_private_flag
> +                                   (FUTEX_WAIT, private), val, tsp);

Don't split function calls before the paren.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."