From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108434 invoked by alias); 9 Dec 2019 12:53:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 108425 invoked by uid 89); 9 Dec 2019 12:53:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,SPF_PASS autolearn=no version=3.3.1 spammy=H*f:sk:mvmlfrl, H*f:sk:2c6ca3f, H*f:sk:mvmeexd, H*i:sk:38b8e5b X-HELO: mx1.suse.de From: Andreas Schwab To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Fix __libc_signal_block_all on sparc64 References: <20191205143526.27478-1-adhemerval.zanella@linaro.org> <2c6ca3f8-e103-fbc4-d13d-05f646ef8e55@linaro.org> <38b8e5bb-d26a-5bf8-3293-0cb7bb8b98e4@linaro.org> X-Yow: Everywhere I look I see NEGATIVITY and ASPHALT... Date: Mon, 09 Dec 2019 12:53:00 -0000 In-Reply-To: <38b8e5bb-d26a-5bf8-3293-0cb7bb8b98e4@linaro.org> (Adhemerval Zanella's message of "Mon, 9 Dec 2019 09:24:06 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00277.txt.bz2 On Dez 09 2019, Adhemerval Zanella wrote: > On 09/12/2019 08:59, Andreas Schwab wrote: >> On Dez 09 2019, Adhemerval Zanella wrote: >> >>> On 09/12/2019 08:00, Andreas Schwab wrote: >>>> On Dez 05 2019, Adhemerval Zanella wrote: >>>> >>>>> Where SIGALL_SET is defined as: >>>>> >>>>> ((__sigset_t) { .__val = {[0 ... _SIGSET_NWORDS-1 ] = -1 } }) >>>> >>>> Why is that not const? >>>> >>>> Andreas. >>>> >>> >>> It is on the updated version [1]. >> >> Does it help to make it const? >> > > It does, that's the main reason for the updated version No, I mean without the other changes. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."