public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: libc-alpha@sourceware.org,  stgraber@stgraber.org,
	 serge@hallyn.com,  fweimer@redhat.com,  joseph@codesourcery.com
Subject: Re: [PATCH 1/2 v4] openpty: close slave pty fd on error
Date: Tue, 29 Aug 2017 14:00:00 -0000	[thread overview]
Message-ID: <mvma82ijwxx.fsf@suse.de> (raw)
In-Reply-To: <20170829134515.9345-1-christian.brauner@ubuntu.com> (Christian Brauner's message of "Tue, 29 Aug 2017 15:45:14 +0200")

On Aug 29 2017, Christian Brauner <christian.brauner@ubuntu.com> wrote:

> @@ -129,12 +124,17 @@ openpty (int *amaster, int *aslave, char *name,
>    if (name != NULL)
>      strcpy (name, buf);
>  
> +  ret = 0;
> +
> + on_error:
> +  close (master);
> +
> +  if (slave != -1)
> +    close(slave);
> +

You don't want to close the fds on success.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

  parent reply	other threads:[~2017-08-29 14:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-26 14:21 [PATCH 1/2] " Christian Brauner
2017-08-26 14:21 ` [PATCH 2/2] openpty: use TIOCGPTPEER to open slave side fd Christian Brauner
2017-08-28  7:34   ` Florian Weimer
2017-08-28 11:14     ` Christian Brauner
2017-08-28 11:39     ` Joseph Myers
2017-08-28 12:11     ` [PATCH 2/2 v2] " Christian Brauner
2017-08-28 12:22       ` Joseph Myers
2017-08-28 12:34       ` Andreas Schwab
2017-08-28 12:51         ` [PATCH 2/2 v3] " Christian Brauner
2017-08-29  9:07 ` [PATCH 1/2] openpty: close slave pty fd on error Florian Weimer
2017-08-29 13:46   ` [PATCH 1/2 v4] " Christian Brauner
2017-08-29 13:46     ` [PATCH 2/2 v4] openpty: use TIOCGPTPEER to open slave side fd Christian Brauner
2017-08-29 14:00     ` Andreas Schwab [this message]
2017-08-29 14:12       ` [PATCH 1/2 v4] openpty: close slave pty fd on error Christian Brauner
2017-08-29 14:31       ` [PATCH 1/2 v5] " Christian Brauner
2017-08-29 14:31         ` [PATCH 2/2 v5] openpty: use TIOCGPTPEER to open slave side fd Christian Brauner
2017-09-10 17:45         ` [PATCH 1/2 v5] openpty: close slave pty fd on error Christian Brauner
2017-09-20 10:53           ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvma82ijwxx.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=christian.brauner@ubuntu.com \
    --cc=fweimer@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=serge@hallyn.com \
    --cc=stgraber@stgraber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).