From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70054 invoked by alias); 29 Aug 2017 14:00:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 57447 invoked by uid 89); 29 Aug 2017 14:00:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.suse.de From: Andreas Schwab To: Christian Brauner Cc: libc-alpha@sourceware.org, stgraber@stgraber.org, serge@hallyn.com, fweimer@redhat.com, joseph@codesourcery.com Subject: Re: [PATCH 1/2 v4] openpty: close slave pty fd on error References: <20170829134515.9345-1-christian.brauner@ubuntu.com> X-Yow: YOW!! Up ahead! It's a DONUT HUT!! Date: Tue, 29 Aug 2017 14:00:00 -0000 In-Reply-To: <20170829134515.9345-1-christian.brauner@ubuntu.com> (Christian Brauner's message of "Tue, 29 Aug 2017 15:45:14 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-08/txt/msg01236.txt.bz2 On Aug 29 2017, Christian Brauner wrote: > @@ -129,12 +124,17 @@ openpty (int *amaster, int *aslave, char *name, > if (name != NULL) > strcpy (name, buf); > > + ret = 0; > + > + on_error: > + close (master); > + > + if (slave != -1) > + close(slave); > + You don't want to close the fds on success. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."