From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118729 invoked by alias); 17 Feb 2020 09:49:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 118718 invoked by uid 89); 17 Feb 2020 09:49:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:8736b9e, H*i:sk:8736b9e, HTo:U*fw X-HELO: mx2.suse.de From: Andreas Schwab To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Always do locking when accessing streams (bug 15142, bug 14697) References: <87y2t2slcq.fsf@mid.deneb.enyo.de> <8736b9eel2.fsf@mid.deneb.enyo.de> X-Yow: Imagine--a WORLD without POODLES... Date: Mon, 17 Feb 2020 09:49:00 -0000 In-Reply-To: <8736b9eel2.fsf@mid.deneb.enyo.de> (Florian Weimer's message of "Mon, 17 Feb 2020 10:40:57 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00740.txt.bz2 On Feb 17 2020, Florian Weimer wrote: > * Andreas Schwab: > >> On Feb 16 2020, Florian Weimer wrote: >> >>> I'm not sure if the justification is correct. We don't know if there >>> are programs which call flockfile on some file and expect exit to >>> still work (and terminate the program), which is part of what >>> nptl/tst-stdio1 tests. >> >> But that's exactly what the bug is about. Random memory corruption >> cannot be the answer. > > Sure, but breaking existing programs so that they never terminate is > not acceptable, either. They were always erroneous. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."