From: Andreas Schwab <schwab@suse.de>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] elf: Count components of the expanded path in _dl_init_path [BZ #22607]
Date: Thu, 14 Dec 2017 13:58:00 -0000 [thread overview]
Message-ID: <mvmh8stjtry.fsf@suse.de> (raw)
In-Reply-To: <75ae8262-9006-6ea2-a9c6-2a17d95cac5b@redhat.com> (Florian Weimer's message of "Thu, 14 Dec 2017 14:48:07 +0100")
On Dez 14 2017, Florian Weimer <fweimer@redhat.com> wrote:
> On 12/14/2017 02:45 PM, Andreas Schwab wrote:
>> On Dez 14 2017, fweimer@redhat.com (Florian Weimer) wrote:
>>
>>> + {
>>> + const char *cp = llp_tmp;
>>> + while (*cp)
>>> + {
>>> + if (*cp == ':' || *cp == ';')
>>> + ++nllp;
>>> + ++cp;
>>> + }
>>> + }
>>
>> No need for the outermost braces.
>
> I included them to limit the scope of cp, to make sure that there aren't
> any uses afterwards because of the changed value of cp compared to the
> original code.
Since it is obviously unused afterwards I don't see any value for that.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2017-12-14 13:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 13:31 Florian Weimer
2017-12-14 13:45 ` Andreas Schwab
2017-12-14 13:48 ` Florian Weimer
2017-12-14 13:58 ` Andreas Schwab [this message]
2017-12-14 14:08 ` Florian Weimer
2017-12-14 14:21 ` Andreas Schwab
2017-12-14 15:28 ` Dmitry V. Levin
2017-12-14 13:53 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmh8stjtry.fsf@suse.de \
--to=schwab@suse.de \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).