From: Andreas Schwab <schwab@suse.de>
To: Alistair Francis <alistair.francis@wdc.com>
Cc: libc-alpha@sourceware.org, alistair23@gmail.com
Subject: Re: [PATCH 1/2] Split up endian.h to minimize exposure of BYTE_ORDER.
Date: Wed, 25 Sep 2019 07:34:00 -0000 [thread overview]
Message-ID: <mvmimpgde3e.fsf@suse.de> (raw)
In-Reply-To: <20190925002903.15928-1-alistair.francis@wdc.com> (Alistair Francis's message of "Tue, 24 Sep 2019 17:29:02 -0700")
On Sep 24 2019, Alistair Francis <alistair.francis@wdc.com> wrote:
> diff --git a/inet/netinet/in.h b/inet/netinet/in.h
> index 148bc663fc7..609ad66bcb8 100644
> --- a/inet/netinet/in.h
> +++ b/inet/netinet/in.h
> @@ -380,9 +380,9 @@ extern uint32_t htonl (uint32_t __hostlong)
> extern uint16_t htons (uint16_t __hostshort)
> __THROW __attribute__ ((__const__));
>
> -#include <endian.h>
>
> /* Get machine dependent optimized versions of byte swapping functions. */
> +#include <bits/endian.h>
> #include <bits/byteswap.h>
> #include <bits/uintn-identity.h>
>
> diff --git a/resolv/arpa/nameser_compat.h b/resolv/arpa/nameser_compat.h
> index f1c390f3b91..37c178b5243 100644
> --- a/resolv/arpa/nameser_compat.h
> +++ b/resolv/arpa/nameser_compat.h
> @@ -29,7 +29,7 @@
> #ifndef _ARPA_NAMESER_COMPAT_
> #define _ARPA_NAMESER_COMPAT_
>
> -#include <endian.h>
> +#include <bits/endian.h>
>
> /*%
> * Structure for query header. The order of the fields is machine- and
Not sure whether we should change the network headers. There are
probably uses that depend on BYTE_ORDER to be defined through them.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2019-09-25 7:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 0:33 Alistair Francis
2019-09-25 0:33 ` [PATCH 2/2] time: Add padding for the timespec if required Alistair Francis
2019-09-25 0:57 ` Joseph Myers
2019-09-25 1:02 ` Alistair Francis
2019-09-25 9:50 ` Lukasz Majewski
2019-09-25 16:24 ` Joseph Myers
2019-09-25 20:05 ` Lukasz Majewski
2019-09-25 7:34 ` Andreas Schwab [this message]
2019-09-25 22:54 ` [PATCH 1/2] Split up endian.h to minimize exposure of BYTE_ORDER Alistair Francis
2019-09-26 7:02 ` Andreas Schwab
2019-09-27 0:56 ` Alistair Francis
2019-09-27 15:38 ` Joseph Myers
2019-09-27 21:40 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmimpgde3e.fsf@suse.de \
--to=schwab@suse.de \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).