From: Andreas Schwab <schwab@linux-m68k.org>
To: Yury Norov <ynorov@caviumnetworks.com>
Cc: <libc-alpha@sourceware.org>, <zackw@panix.com>, <arnd@arndb.de>
Subject: Re: [PATCH v2] Linux: consolidate rename()
Date: Thu, 20 Oct 2016 07:11:00 -0000 [thread overview]
Message-ID: <mvminsno5qf.fsf@hawking.suse.de> (raw)
In-Reply-To: <1476924756-31448-1-git-send-email-ynorov@caviumnetworks.com> (Yury Norov's message of "Thu, 20 Oct 2016 03:52:36 +0300")
On Okt 20 2016, Yury Norov <ynorov@caviumnetworks.com> wrote:
> diff --git a/sysdeps/unix/sysv/linux/rename.c b/sysdeps/unix/sysv/linux/rename.c
> new file mode 100644
> index 0000000..8e14d7d
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/rename.c
This overrides the unix/syscalls.list entry, thus architectures which
implement the rename syscall no longer use it.
> @@ -0,0 +1,27 @@
> +/* rename() implemantation.
> + Copyright (C) 2016 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> + Contributed by Chris Metcalf <cmetcalf@tilera.com>, 2011.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library. If not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +#include <fcntl.h>
> +
> +/* Rename the file OLD to NEW. */
> +int
> +rename (const char *old, const char *new)
> +{
> + return renameat (AT_FDCWD, old, AT_FDCWD, new);
> +}
../sysdeps/unix/sysv/linux/rename.c: In function ârenameâ:
../sysdeps/unix/sysv/linux/rename.c:26:3: error: implicit declaration of function ârenameatâ [-Werror=implicit-function-declaration]
return renameat (AT_FDCWD, old, AT_FDCWD, new);
^
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2016-10-20 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 0:53 Yury Norov
2016-10-20 7:11 ` Andreas Schwab [this message]
2016-10-20 11:23 ` Yury Norov
2016-10-20 12:35 ` Andreas Schwab
2016-10-20 12:53 ` Yury Norov
2016-10-20 13:16 ` Joseph Myers
2016-10-20 13:58 ` Adhemerval Zanella
2016-10-20 15:32 ` Joseph Myers
2016-10-20 16:55 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvminsno5qf.fsf@hawking.suse.de \
--to=schwab@linux-m68k.org \
--cc=arnd@arndb.de \
--cc=libc-alpha@sourceware.org \
--cc=ynorov@caviumnetworks.com \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).