From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68328 invoked by alias); 20 Oct 2016 07:11:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 68164 invoked by uid 89); 20 Oct 2016 07:11:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=H*r:192.168.8, 942b, 54C7, 44D5 X-HELO: mail-out.m-online.net X-Auth-Info: KXni+rThnd9UbnP441gMsliuBs98Exj4Nb8jRt5fQem4vOza3siVqeFC8xkMop+c From: Andreas Schwab To: Yury Norov Cc: , , Subject: Re: [PATCH v2] Linux: consolidate rename() References: <1476924756-31448-1-git-send-email-ynorov@caviumnetworks.com> X-Yow: Now I can join WEIGHT WATCHERS! Date: Thu, 20 Oct 2016 07:11:00 -0000 In-Reply-To: <1476924756-31448-1-git-send-email-ynorov@caviumnetworks.com> (Yury Norov's message of "Thu, 20 Oct 2016 03:52:36 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-10/txt/msg00330.txt.bz2 On Okt 20 2016, Yury Norov wrote: > diff --git a/sysdeps/unix/sysv/linux/rename.c b/sysdeps/unix/sysv/linux/rename.c > new file mode 100644 > index 0000000..8e14d7d > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/rename.c This overrides the unix/syscalls.list entry, thus architectures which implement the rename syscall no longer use it. > @@ -0,0 +1,27 @@ > +/* rename() implemantation. > + Copyright (C) 2016 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + Contributed by Chris Metcalf , 2011. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +#include > + > +/* Rename the file OLD to NEW. */ > +int > +rename (const char *old, const char *new) > +{ > + return renameat (AT_FDCWD, old, AT_FDCWD, new); > +} ../sysdeps/unix/sysv/linux/rename.c: In function ‘rename’: ../sysdeps/unix/sysv/linux/rename.c:26:3: error: implicit declaration of function ‘renameat’ [-Werror=implicit-function-declaration] return renameat (AT_FDCWD, old, AT_FDCWD, new); ^ Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."