From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id EA1F5383139E for ; Tue, 22 Aug 2023 11:14:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EA1F5383139E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id E70DF22C45; Tue, 22 Aug 2023 11:14:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1692702883; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RSCQiQI1Mmk1ZhCkppiS40TApkuo/hzgzV1NbqK9JJE=; b=0ZlHSKPAEpEWCmDousRNrdTff9M1U8lM5wC1RYq2/2unK2hCUMrXbSmpJEixq1d84xVPkv JVqcC32Kzh8pzWoOUuqlDkz/DZO+JusJ0Bn0IN8XuqVRdNfg6dQQNZo7mr0dk3letGrq2r Sxighywx21O5xR0saOnzpO1QaW4UnjU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1692702883; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RSCQiQI1Mmk1ZhCkppiS40TApkuo/hzgzV1NbqK9JJE=; b=o1P5ecITq1TyQdU0l4/OYs3zL/wSxmQeVpH0umCUXNqOXr6PeipmgcE9LTX6RApC7LO8MI E171HiUsxbcX/rBw== Received: from hawking.nue2.suse.org (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id E1A952C143; Tue, 22 Aug 2023 11:14:43 +0000 (UTC) Received: by hawking.nue2.suse.org (Postfix, from userid 17005) id CF9734AB2B6; Tue, 22 Aug 2023 13:14:43 +0200 (CEST) From: Andreas Schwab To: Florian Weimer via Libc-alpha Cc: Florian Weimer Subject: Re: [PATCH v3 1/2] elf: Do not run constructors for proxy objects In-Reply-To: (Florian Weimer via Libc-alpha's message of "Tue, 22 Aug 2023 12:58:29 +0200") References: X-Yow: I always liked FLAG DAY!! Date: Tue, 22 Aug 2023 13:14:43 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Aug 22 2023, Florian Weimer via Libc-alpha wrote: > diff --git a/elf/dl-init.c b/elf/dl-init.c > index 5b0732590f..fefd471851 100644 > --- a/elf/dl-init.c > +++ b/elf/dl-init.c > @@ -25,6 +25,10 @@ > static void > call_init (struct link_map *l, int argc, char **argv, char **env) > { > + /* Do not run constructors for proxy objects. */ > + if (l != l->l_real) > + return; > + > /* If the object has not been relocated, this is a bug. The > function pointers are invalid in this case. (Executables do not > need relocation, and neither do proxy objects.) */ Now that we know that l == l->l_real, the following assertion does not need to indirect through l_real any more. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."