From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 1137D3858C50 for ; Mon, 15 May 2023 15:22:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1137D3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 09C521FD63; Mon, 15 May 2023 15:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684164140; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gthYi4Lerl94J8vMfpgb+teCahgLh+LyylrxZGvBRP0=; b=gewM7SZtQmUuqpQipqn9yLzRPZivqjplLjcE4mpTjpm+ITnjHGi3VOue6V40i18cdf4giC D1GNw0D3djiVXgSy6SSq+pMTYIoPy1Qr9Ld3FiOyfLuQT97QQyGiLWCDWV0RjoOAuldST+ HWh2shvcQGby4xDcQi9CJKbu8VOnxvw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684164140; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gthYi4Lerl94J8vMfpgb+teCahgLh+LyylrxZGvBRP0=; b=4lZRcx8Le16s6PWMakSX6my+sak9JyfaCuAl7jn/iLweWdMYdv6xJxz9pkezxi6caL+QVB 92eGWbt1EV6mH8Bw== Received: from hawking.suse.de (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id F01B42C141; Mon, 15 May 2023 15:22:19 +0000 (UTC) Received: by hawking.suse.de (Postfix, from userid 17005) id BA1394A03B2; Mon, 15 May 2023 17:22:19 +0200 (CEST) From: Andreas Schwab To: Sergey Bugaev via Libc-alpha Cc: Sergey Bugaev Subject: Re: [RFC PATCH 1/6] Mark more functions as __COLD In-Reply-To: <20230515144815.3939017-2-bugaevc@gmail.com> (Sergey Bugaev via Libc-alpha's message of "Mon, 15 May 2023 17:48:10 +0300") References: <20230515144815.3939017-1-bugaevc@gmail.com> <20230515144815.3939017-2-bugaevc@gmail.com> X-Yow: It's the land of DONNY AND MARIE as promised in TV GUIDE! Date: Mon, 15 May 2023 17:22:19 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mai 15 2023, Sergey Bugaev via Libc-alpha wrote: > diff --git a/include/stdio.h b/include/stdio.h > index da47d1ce..b5257dd5 100644 > --- a/include/stdio.h > +++ b/include/stdio.h > @@ -171,9 +171,11 @@ extern int __gen_tempname (char *__tmpl, int __suffixlen, int __flags, > /* Print out MESSAGE (which should end with a newline) on the error output > and abort. */ > extern void __libc_fatal (const char *__message) > - __attribute__ ((__noreturn__)); > -_Noreturn void __libc_message (const char *__fnt, ...) attribute_hidden; > -extern void __fortify_fail (const char *msg) __attribute__ ((__noreturn__)); > + __attribute__ ((__noreturn__)) __COLD; > +extern void __libc_message (const char *__fnt, ...) > + attribute_hidden __attribute__ ((__noreturn__)) __COLD; Any reason you replaced _Noreturn with __attribute__ ((__noreturn__)) here ... > diff --git a/malloc/malloc.c b/malloc/malloc.c > index 5d8b61d6..75e4eb2f 100644 > --- a/malloc/malloc.c > +++ b/malloc/malloc.c > @@ -1093,7 +1093,7 @@ static void* _int_memalign(mstate, size_t, size_t); > static void* _mid_memalign(size_t, size_t, void *); > #endif > > -static void malloc_printerr(const char *str) __attribute__ ((noreturn)); > +_Noreturn static void malloc_printerr(const char *str) __COLD; ... but did the other way here? -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."