From: Andreas Schwab <schwab@suse.de>
To: Lukasz Majewski <lukma@denx.de>
Cc: Joseph Myers <joseph@codesourcery.com>,
Paul Eggert <eggert@cs.ucla.edu>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Alistair Francis <alistair23@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>,
Carlos O'Donell <carlos@redhat.com>,
Stepan Golosunov <stepan@golosunov.pp.ru>,
Zack Weinberg <zackw@panix.com>, Jeff Law <law@redhat.com>
Subject: Re: [PATCH 2/2] nptl: Provide NULL abstime pointer handling in __futex_abstimed_wait_cancelable32
Date: Wed, 16 Sep 2020 14:06:34 +0200 [thread overview]
Message-ID: <mvmk0wuq62d.fsf@suse.de> (raw)
In-Reply-To: <20200916110738.9904-2-lukma@denx.de> (Lukasz Majewski's message of "Wed, 16 Sep 2020 13:07:38 +0200")
On Sep 16 2020, Lukasz Majewski wrote:
> This change fixes issue when NULL pointer would be passed to
> __futex_abstimed_wait_cancelable32.
>
> The call log for passing NULL as *abstime pointer.
> sem_wait (versioned symbol)
> |
> \|/
> __new_sem_wait
> | (here the NULL is passed as *abstime)
> \|/
> __new_sem_wait_slow64
> |
> \|/
> do_futex_wait
> |
> \|/
> __futex_abstimed_wait_cancelable64
> |
> \|/
> __futex_abstimed_wait_cancellable32
This is now __futex_abstimed_wait_cancelable32.
> In this function the *abstime is dereferenced when checking if we have
> time_t in range and when converting to 32 bit struct timespec to pass it
> to futex syscall, which supports 32 bit time.
Ok.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2020-09-16 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 11:07 [PATCH 1/2] nptl: Provide proper spelling for 32 bit version of futex_abstimed_wait Lukasz Majewski
2020-09-16 11:07 ` [PATCH 2/2] nptl: Provide NULL abstime pointer handling in __futex_abstimed_wait_cancelable32 Lukasz Majewski
2020-09-16 12:06 ` Andreas Schwab [this message]
2020-09-16 14:59 ` Alistair Francis
2020-09-16 12:04 ` [PATCH 1/2] nptl: Provide proper spelling for 32 bit version of futex_abstimed_wait Andreas Schwab
2020-09-16 14:56 ` Alistair Francis
2020-09-29 16:52 ` Lukasz Majewski
2020-09-29 18:11 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmk0wuq62d.fsf@suse.de \
--to=schwab@suse.de \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=arnd@arndb.de \
--cc=carlos@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=law@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=lukma@denx.de \
--cc=stepan@golosunov.pp.ru \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).