From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id E51843858020 for ; Mon, 28 Nov 2022 13:55:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E51843858020 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 09FE01F74A; Mon, 28 Nov 2022 13:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669643720; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=98uJqTAkFFqqcO0tFIhhX0CXu+XbzSVBOsnJJhpZZCk=; b=EYNwe3MEaV7I/mNOCibIjEMVGO/B1VRJnI/bHT0FYFpsdKWZhpYEUl1XJb2R/KmoMSq583 d66XsjhdY0qbE8EzFYDkzlsPkpFN71JBf37Yi0WxZxLLU8H3MoqXWynpYrucU+fgUdPqhy pOtYHERwCfC7YhXUPup4hGFGpNcVazI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669643720; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=98uJqTAkFFqqcO0tFIhhX0CXu+XbzSVBOsnJJhpZZCk=; b=Oely6u230PZm51NSluTmqPpwjjk5ckxJfkuY4dy5hkpSw0bSAE/Ybds0c7SchSmL/M3t2C ollcwbfKiA0hqnCA== Received: from hawking.suse.de (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id 02F912C141; Mon, 28 Nov 2022 13:55:19 +0000 (UTC) Received: by hawking.suse.de (Postfix, from userid 17005) id 6B06144017F; Mon, 28 Nov 2022 14:55:19 +0100 (CET) From: Andreas Schwab To: Florian Weimer via Libc-alpha Cc: Florian Weimer Subject: Re: [PATCH] : Make strptime available by default References: <87lenvrzey.fsf@oldenburg.str.redhat.com> X-Yow: These PRESERVES should be FORCE-FED to PENTAGON OFFICIALS!! Date: Mon, 28 Nov 2022 14:55:18 +0100 In-Reply-To: <87lenvrzey.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Mon, 28 Nov 2022 14:17:41 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Nov 28 2022, Florian Weimer via Libc-alpha wrote: > This matches what FreeBSD does. Does it? What I see is that the strptime declaration is conditional on __XSI_VISIBLE, which is their equivalent of __USE_XOPEN, I think. > diff --git a/time/time.h b/time/time.h > index d18089116e..f507b44228 100644 > --- a/time/time.h > +++ b/time/time.h > @@ -101,7 +101,7 @@ extern size_t strftime (char *__restrict __s, size_t __maxsize, > const char *__restrict __format, > const struct tm *__restrict __tp) __THROW; > > -#ifdef __USE_XOPEN > +#if (defined __USE_XOPEN || defined __USE_MISC) No need for parens. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."