From: Andreas Schwab <schwab@suse.de>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
<libc-alpha@sourceware.org>,
<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH] tst-tzset: raise timeout to 10 seconds
Date: Mon, 30 Jul 2018 16:07:00 -0000 [thread overview]
Message-ID: <mvmmuu8vh9m.fsf@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1807301555590.17805@digraph.polyomino.org.uk> (Joseph Myers's message of "Mon, 30 Jul 2018 15:58:06 +0000")
On Jul 30 2018, Joseph Myers <joseph@codesourcery.com> wrote:
> On Mon, 30 Jul 2018, Alexey Brodkin wrote:
>
>> diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c
>> index 27f986b56dab..534f7acdf75f 100644
>> --- a/timezone/tst-tzset.c
>> +++ b/timezone/tst-tzset.c
>> @@ -25,7 +25,7 @@
>> #include <time.h>
>> #include <unistd.h>
>>
>> -#define TIMEOUT 5
>> +#define TIMEOUT 10
>
> The timeout was set to 5 in commit
> 112f28e88c4ea5afbd6050e71416a23db11e4adc to increase it from a default 2
> seconds. That was before the default timeout was changed to 20 seconds in
> commit a28605b22946c708f0a5c4f06307e1a17650ced8. In such cases I think we
> should remove the timeout setting - explicit timeouts less than the
> default are only appropriate where there is a strong reason to want to
> *decrease* the default timeout.
There are a lot of tests that set TIMEOUT to less than 20.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2018-07-30 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 15:28 Alexey Brodkin
2018-07-30 15:58 ` Joseph Myers
2018-07-30 16:07 ` Andreas Schwab [this message]
2018-07-30 16:51 ` Florian Weimer
2018-07-30 17:12 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmmuu8vh9m.fsf@suse.de \
--to=schwab@suse.de \
--cc=Alexey.Brodkin@synopsys.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).