From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 1DBAF3858D20 for ; Mon, 29 Jan 2024 12:46:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DBAF3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1DBAF3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706532373; cv=none; b=IWordKVcGHhGJp/isty12qHSWXvkJJ7swWL7R2RCrUkHcDtUrvNAZ0E17ADyaxQugGuztSNZ7bAqkv/ATEiZDmXejk9ucJAOaT+jZzSZo2ijLdrhTEHWKRq+UKmaLv8k2myDg3CWSIIexRvU2799/cz0GICh/Q5CUgl4QqKVuUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706532373; c=relaxed/simple; bh=UqEFw/ICImkQhwuWPSQBU3UgWb7rFefR9OWsE0FHJCE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=Xmc8FyOsS/hZgGIpwyazwxQxcOu8SMnjIgvtU0UIwA4QkApPUdFUJXkwCyoSAoAB3CEKhVMxzQLgOUj6VP+onEfirg3AMNRBu10qGVmUVLatstWWsTqaNuUDby1dpJKI3p6qiueV6rWelvVOl0dNcdBXYnEpPizfsjqVuQEkecc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from hawking.nue2.suse.org (unknown [10.168.4.11]) by smtp-out1.suse.de (Postfix) with ESMTP id A5A532209F; Mon, 29 Jan 2024 12:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706532366; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ODHhij5Jx/zoxDuWpaozg74BvL8gvOOcC6RFhMmmXhs=; b=1Isnhz7+CEm/ipuwsuKpgaHMztTzzMq3Ej+5py32MWvZgx0SOJIopo4WG5Ws3V/B4SuoFs zcwvNIQDW8TK6okA2e0UnNiZYghv/H6meRymYLCNQKUzsEY3aEIO5fwUO99dGxZCT2wtHF W8NoWdccJ8ds21TSSWLqgRN7xj14Q68= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706532366; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ODHhij5Jx/zoxDuWpaozg74BvL8gvOOcC6RFhMmmXhs=; b=M1Q1pkqjlymS+Kbc1jDwHHzDI8CcElrHa+4RP1lL0dZHBusgiNwlTBQDMyEHshQnCETjTt DR20sG2NBAOfU9Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706532364; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ODHhij5Jx/zoxDuWpaozg74BvL8gvOOcC6RFhMmmXhs=; b=D9ShKElolCF8axLqB3vdDhIsjxj94kIUq6Np+9aYKGfApdlunSz+tftbdvKIjyyYnOQT4E ssbF3WUMJ+yEFtBpSxxTME4vw50Q5u/2nm11NOs6N0L+MLqIJ2qWhkrW+LsZUQTwIFXgns FcbSjSxsry+sfzwzlqw1DALIo/IhiwU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706532364; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ODHhij5Jx/zoxDuWpaozg74BvL8gvOOcC6RFhMmmXhs=; b=BoB9GgaKUoeVFfz/5RgTlj447dg3w/aTljfyEPPE6k5x+9Srhncyj02L+ETIt07OD50b1l TehQQiitDB2XQmBA== Received: by hawking.nue2.suse.org (Postfix, from userid 17005) id 994754A04E5; Mon, 29 Jan 2024 13:46:04 +0100 (CET) From: Andreas Schwab To: yanzhang.wang@intel.com Cc: libc-alpha@sourceware.org, adhemerval.zanella@linaro.org Subject: Re: [PATCH v3] RISC-V: Enable static-pie. In-Reply-To: <20240102105415.516313-1-yanzhang.wang@intel.com> (yanzhang wang's message of "Tue, 2 Jan 2024 18:54:15 +0800") References: <20230810233348.1214955-1-yanzhang.wang@intel.com> <20240102105415.516313-1-yanzhang.wang@intel.com> X-Yow: Here we are in America... when do we collect unemployment? Date: Mon, 29 Jan 2024 13:46:04 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-2.58 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-2.48)[97.62%] X-Spam-Level: X-Spam-Score: -2.58 X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Jan 02 2024, yanzhang.wang@intel.com wrote: > diff --git a/sysdeps/riscv/dl-machine.h b/sysdeps/riscv/dl-machine.h > index ffb8c4aaa0..0cbb476c05 100644 > --- a/sysdeps/riscv/dl-machine.h > +++ b/sysdeps/riscv/dl-machine.h > @@ -348,7 +348,7 @@ elf_machine_runtime_setup (struct link_map *l, struct r_scope_elem *scope[], > gotplt[1] = (ElfW(Addr)) l; > } > > - if (l->l_type == lt_executable) > + if (l->l_type == lt_executable && l->l_scope != NULL) This is not the right way to test for static PIE, it tries to access a non-relocated non-zero pointer. The mold linker, when producing relative relocations, puts the addend both in the relocation addend and the relocated field, which is perfectly valid to do, so this is non-zero here. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."