From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-91179-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 67751 invoked by alias); 20 Mar 2018 08:58:47 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 67349 invoked by uid 89); 20 Mar 2018 08:58:46 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=
X-HELO: mx2.suse.de
From: Andreas Schwab <schwab@suse.de>
To: Andrew Senkevich <andrew.n.senkevich@gmail.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,  Florian Weimer <fweimer@redhat.com>,  Szabolcs Nagy <szabolcs.nagy@arm.com>,  nd <nd@arm.com>,  libc-alpha <libc-alpha@sourceware.org>,  Max Horn <max@quendi.de>,  thomas@grindinggear.com
Subject: Re: [PATCH] Fix i386 memmove issue [BZ #22644]
References: <CAMXFM3s5b2a6o_CMS0cJ35oE3SuJUHssqLAUY94LSZhEEtG71A@mail.gmail.com>
	<mvm606ts2w6.fsf@suse.de>
	<CAMXFM3vqw7eiUT1XYVZWyW=eJkgEpjNc74A8mbmdKuR_hywN3w@mail.gmail.com>
	<CAMe9rOo4Ys=ScEKKnuv5XvYqTHjvFxSkXjch8ya8sX7dfP+q4Q@mail.gmail.com>
	<CAMXFM3vA=-LSK5VtKhhbs0g9faBdG0GjoAbNb6OPEbSt8dAA7A@mail.gmail.com>
	<mvmlgeojjmi.fsf@suse.de>
	<597954a1-85da-e524-1454-27c46af57413@redhat.com>
	<e7d81f18-315c-4434-a734-41029c0d387f@arm.com>
	<8c8ab285-bddc-90e6-a50e-7be89703367a@redhat.com>
	<CAMXFM3s39wwjHt=5PBp=Np8Rp=mXHfPwMq6_evtfx9MV08-mtQ@mail.gmail.com>
	<CAMe9rOoCe+qiOFK8=dwxm+eB=_wSoHbXdid0RKSUHqOtM7Wwfg@mail.gmail.com>
	<CAMXFM3vWVVbe0unZaueF+u62KJ-Sxa6ttMdZRaf_UesxMU=ZKA@mail.gmail.com>
	<CAMe9rOqsVpCV24f7g=kpFeOAQ_rkHuj-ZN5TDqs7BZ814BDQkg@mail.gmail.com>
	<CAMXFM3ujXmdgVyew8mY7h=tMhEH+qdALnke6iavecPnX-rVz_Q@mail.gmail.com>
X-Yow: I'm pretending I'm pulling in a TROUT!  Am I doing it correctly??
Date: Tue, 20 Mar 2018 08:58:00 -0000
In-Reply-To: <CAMXFM3ujXmdgVyew8mY7h=tMhEH+qdALnke6iavecPnX-rVz_Q@mail.gmail.com>
	(Andrew Senkevich's message of "Mon, 19 Mar 2018 21:32:27 +0100")
Message-ID: <mvmo9jji0n3.fsf@suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-SW-Source: 2018-03/txt/msg00486.txt.bz2

On Mär 19 2018, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote:

> diff --git a/string/test-memmove.c b/string/test-memmove.c
> index edc7a4c..9f1437d 100644
> --- a/string/test-memmove.c
> +++ b/string/test-memmove.c
> @@ -24,6 +24,7 @@
>  # define TEST_NAME "memmove"
>  #endif
>  #include "test-string.h"
> +#include <support/test-driver.h>
>
>  char *simple_memmove (char *, const char *, size_t);
>
> @@ -245,6 +246,60 @@ do_random_tests (void)
>      }
>  }
>
> +static void
> +do_test2 (void)
> +{
> +  size_t size = 0x20000000;
> +  uint32_t * large_buf;
> +
> +  large_buf = mmap ((void*)0x70000000, size, PROT_READ | PROT_WRITE,
> +     MAP_PRIVATE | MAP_ANON, -1, 0);

Style: line up indentation with paren.

> +
> +  if (large_buf == MAP_FAILED)
> +    error (EXIT_UNSUPPORTED, errno, "Large mmap failed");
> +
> +  if ((uintptr_t)large_buf > 0x80000000 - 128
> +      || 0x80000000 - (uintptr_t)large_buf > 0x20000000)

Style: space after cast.

> +    {
> +      error (0, 0,"Large mmap allocated improperly");

Style: space after comma.

> +      ret = EXIT_UNSUPPORTED;
> +      munmap((void *)large_buf, size);

Style: space before paren and after cast.

> +      return;
> +    }
> +
> +  size_t bytes_move = 0x80000000 - (uintptr_t)large_buf;

Style: space after cast.

> +  size_t arr_size = bytes_move / sizeof(uint32_t);

Style: space before paren.

> +  size_t i;
> +
> +  FOR_EACH_IMPL (impl, 0)
> +    {
> +      for (i = 0; i < arr_size; i++)
> +        large_buf[i] = i;
> +
> +      uint32_t * dst = &large_buf[33];
> +
> +#ifdef TEST_BCOPY
> +      CALL (impl, (char *)large_buf, (char *)dst, bytes_move);
> +#else
> +      CALL (impl, (char *)dst, (char *)large_buf, bytes_move);
> +#endif

Styles: space after cast.

> +
> +      for (i = 0; i < arr_size; i++)
> +        {
> +          if (dst[i] != i)
> +     {

Style: wrong indentation.

> +       error (0, 0,
> +      "Wrong result in function %s dst \"%p\" src \"%p\" offset \"%d\"",
> +      impl->name, dst, large_buf, i);

Style: line up indentation with paren.

> +       ret = 1;
> +       break;
> +     }
> + }
> +    }
> +
> +  munmap((void *)large_buf, size);

Style: space before paren and after cast.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."