From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-75636-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 17275 invoked by alias); 8 Dec 2016 08:23:10 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 17256 invoked by uid 89); 8 Dec 2016 08:23:08 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx2.suse.de
From: Andreas Schwab <schwab@suse.de>
To: Steve Ellcey <sellcey@caviumnetworks.com>
Cc: <libc-alpha@sourceware.org>,  Yury Norov <ynorov@caviumnetworks.com>
Subject: Re: [PATCH 2/2] Enable ILP32 mode on aarch64 (version 2)
References: <1481060942.29811.41.camel@caviumnetworks.com>
	<mvm8trshs75.fsf@hawking.suse.de>
	<1481130334.29811.57.camel@caviumnetworks.com>
X-Yow: I'm having fun HITCHHIKING to CINCINNATI or FAR ROCKAWAY!!
Date: Thu, 08 Dec 2016 08:23:00 -0000
In-Reply-To: <1481130334.29811.57.camel@caviumnetworks.com> (Steve Ellcey's
	message of "Wed, 7 Dec 2016 09:05:34 -0800")
Message-ID: <mvmoa0mhlsw.fsf@hawking.suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-SW-Source: 2016-12/txt/msg00264.txt.bz2

On Dez 07 2016, Steve Ellcey <sellcey@caviumnetworks.com> wrote:

> On Wed, 2016-12-07 at 12:52 +0100, Andreas Schwab wrote:
>
>> > 
>> > +#define STATFS_IS_STATFS64	1
>> This is a lie. You are using .../generic/bits/statfs.h, which assumes
>> that fsblkcnt64_t == 2* fsblkcnt_t (etc.), but ILP32 wants them to be
>> the same.
>
> So it looks like there are two choices, change STATFS_IS_STATFS64 to
> __STATFS_IS_STATFS64 so that I can use it to
> ifdef generic/bits/statfs.h without polluting the namespace or
> introduce a new aarch64/bits/statfs.h header to use instead of
> generic/bits/statfs.h.  Is there a preference one way or the other?
> My inclination is to create a new header file.

I agree.  The X_IS_Y defines should be kept internal.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."