From: Andreas Schwab <schwab@suse.de>
To: Steve Ellcey <sellcey@cavium.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Allow [f]statfs64 to alias [f]statfs
Date: Thu, 17 Nov 2016 08:53:00 -0000 [thread overview]
Message-ID: <mvmpolu32tn.fsf@hawking.suse.de> (raw)
In-Reply-To: <201611072213.uA7MDcpB020773@sellcey-lt.caveonetworks.com> (Steve Ellcey's message of "Mon, 7 Nov 2016 14:13:38 -0800")
On Nov 07 2016, Steve Ellcey <sellcey@cavium.com> wrote:
> My main question is, is this an OK use of '#ifdef' or should the
> STATFS_IS_STATFS64 be defined on all platforms (presumably in kernel_stat.h)
> so that we can check the value instead of checking to see it is defined
> or not?
Since it is a new symbol it should follow the policy of always being
defined.
> * sysdeps/unix/sysv/linux/fstatfs64.c: Make __fstatfs and fstatfs
> aliases of __fstatfs64 if __STATFS_IS_STATFS64 is set.
> * sysdeps/unix/sysv/linux/statfs64.c: Ditto for __statfs, statfs,
> and __statfs64.
> * sysdeps/unix/sysv/linux/generic/wordsize-32/fstatfs.c: Do not
> define __fstatfs and fstatfs if __STATFS_IS_STATFS64 is set.
> * sysdeps/unix/sysv/linux/generic/wordsize-32/statfs.c: Ditto
> for __statfs and statfs.
It's STATFS_IS_STATFS64, not __STATFS_IS_STATFS64.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2016-11-17 8:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 22:13 Steve Ellcey
2016-11-09 21:21 ` Steve Ellcey
2016-11-16 22:55 ` Steve Ellcey
2016-11-17 8:53 ` Andreas Schwab [this message]
2016-11-17 18:34 ` Steve Ellcey
2016-11-21 18:07 ` Steve Ellcey
2016-11-22 13:16 ` Andreas Schwab
2016-11-23 1:20 ` Joseph Myers
2016-11-23 16:23 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmpolu32tn.fsf@hawking.suse.de \
--to=schwab@suse.de \
--cc=libc-alpha@sourceware.org \
--cc=sellcey@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).