From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=itb5=CV=suse.de=schwab@sourceware.org>
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
	by sourceware.org (Postfix) with ESMTPS id B2BC03858CDB
	for <libc-alpha@sourceware.org>; Mon,  3 Jul 2023 07:34:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2BC03858CDB
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
	by smtp-out2.suse.de (Postfix) with ESMTP id E25141F38C;
	Mon,  3 Jul 2023 07:34:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1688369665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=JAxUeKOoxjWqcvyWIdf3i8cwJuveoU8dbBm74uQl9RE=;
	b=dD8XGqNuEau4UT6+o4aZb0CHRuEaFBhS01rcsWmqnWwNlZ0k48Sp3+Vav1YqEcpHeZy6PE
	ACrBZc+khZAqTUvIOkGRNluW5Ld9Xn2cSM1b1KJnk49tNAdJaAjJz7t1Ue2DoypNSeGeaE
	38rjuT7lI244ZlxGU+nCtgluvVZd+24=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1688369665;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=JAxUeKOoxjWqcvyWIdf3i8cwJuveoU8dbBm74uQl9RE=;
	b=LDDCyzBl728gmF4btAqDUVhBkU+wKFlw/OQdA/Hy/qPrnOQt932lSithaiv72Bd41QYqoI
	uuqoP3MQBSqBUIAg==
Received: from hawking.nue2.suse.org (unknown [10.168.4.11])
	by relay2.suse.de (Postfix) with ESMTP id D5A7E2C141;
	Mon,  3 Jul 2023 07:34:25 +0000 (UTC)
Received: by hawking.nue2.suse.org (Postfix, from userid 17005)
	id BBE014A04CB; Mon,  3 Jul 2023 09:34:25 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: Florian Weimer <fweimer@redhat.com>
Cc: Andreas Schwab via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Always do locking when accessing streams (bug 15142,
 bug 14697)
In-Reply-To: <878rc1vt7g.fsf@oldenburg.str.redhat.com> (Florian Weimer's
	message of "Fri, 30 Jun 2023 17:57:23 +0200")
References: <mvmbkgyv2j5.fsf@suse.de>
	<878rc1vt7g.fsf@oldenburg.str.redhat.com>
X-Yow: I want a VEGETARIAN BURRITO to go..  with EXTRA MSG!!
Date: Mon, 03 Jul 2023 09:34:25 +0200
Message-ID: <mvmr0pptpmm.fsf@suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Jun 30 2023, Florian Weimer wrote:

> * Andreas Schwab via Libc-alpha:
>
>> Now that abort no longer calls fflush there is no reason to avoid locking
>> the stdio streams anywhere.  This fixes a conformance issue and potential
>> heap corruption during exit.
>
> Mechanics of the patch look okay to me.  In the end, we may have to make
> this configurable if too many applications hang during shutdown, but I
> think we should put it into the upcoming release.

This has been part of SUSE/openSUSE for several years, and I have not
seen any complaints so far.  It's more likely that you get a crash
during the unlocked access to the streams.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."