From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <schwab@suse.de>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
	by sourceware.org (Postfix) with ESMTPS id 5E45B3947C25
	for <libc-alpha@sourceware.org>; Thu,  6 Oct 2022 13:42:25 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E45B3947C25
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
	by smtp-out1.suse.de (Postfix) with ESMTP id 7562D21A0E;
	Thu,  6 Oct 2022 13:42:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1665063744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ODatQ5CpnJao/v0//4pVdPnt1dLwVCNtQvmbd0KVqb8=;
	b=OEj6GfISeT9EnYZ2nO/WrhuQBbSPQlDHdXngcmSVZH8tuMsh3PNMkn2yW6cPdfbV7IwYGi
	152dawFBPFKqf8vxJHq8Msv31LIM83ZfaKdvO3NaKdZUGeubFAI1pVuHl8L2mjIlsocMFO
	Ae9alOdjBdQxgxmny6l1PqMSWtrIMKg=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1665063744;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ODatQ5CpnJao/v0//4pVdPnt1dLwVCNtQvmbd0KVqb8=;
	b=RRvg0Ex1k/8tVLGXdqyhoQrM6lVYcMm3suZ9uzWCv9sD1YclQ4txcS6T2vnz5ldwnfov8/
	CU/DmwhyOpgipmBg==
Received: from hawking.suse.de (unknown [10.168.4.11])
	by relay2.suse.de (Postfix) with ESMTP id 547F72C16F;
	Thu,  6 Oct 2022 13:42:24 +0000 (UTC)
Received: by hawking.suse.de (Postfix, from userid 17005)
	id F1D664401E9; Thu,  6 Oct 2022 15:42:23 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: Letu Ren via Libc-alpha <libc-alpha@sourceware.org>
Cc: Letu Ren <fantasquex@gmail.com>,  fweimer@redhat.com,
  joseph@codesourcery.com
Subject: Re: [PATCH v4] stdlib/strfrom: Add copysign to fix NAN issue on
 riscv (BZ #29501)
References: <20221006132218.14696-1-fantasquex@gmail.com>
X-Yow: Well, I'm on the right planet---everyone looks like me!!!
Date: Thu, 06 Oct 2022 15:42:23 +0200
In-Reply-To: <20221006132218.14696-1-fantasquex@gmail.com> (Letu Ren via
	Libc-alpha's message of "Thu, 6 Oct 2022 21:22:18 +0800")
Message-ID: <mvmsfk1f4qo.fsf@suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Okt 06 2022, Letu Ren via Libc-alpha wrote:

> @@ -61,7 +62,7 @@ STRFROM (char *dest, size_t size, const char *format, FLOAT f)
>       because __printf_fp and __printf_fphex only accept double and long double
>       as the floating-point argument.  */
>    if (__builtin_types_compatible_p (FLOAT, float))
> -    fpnum.flt = f;
> +    fpnum.flt = keep_sign_conversion(f);

Style: space before paren.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."