From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <schwab@suse.de>
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by sourceware.org (Postfix) with ESMTPS id BD83D3858C2D
 for <libc-alpha@sourceware.org>; Tue, 16 Aug 2022 09:44:36 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BD83D3858C2D
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out2.suse.de (Postfix) with ESMTP id D71731F88D;
 Tue, 16 Aug 2022 09:44:35 +0000 (UTC)
Received: from hawking.suse.de (unknown [10.168.4.11])
 by relay2.suse.de (Postfix) with ESMTP id D10262C143;
 Tue, 16 Aug 2022 09:44:35 +0000 (UTC)
Received: by hawking.suse.de (Postfix, from userid 17005)
 id 72350444B1D; Tue, 16 Aug 2022 11:44:35 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Cc: Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] Linux: Fix enum fsconfig_command detection in
 <sys/mount.h>
References: <87a684ejbj.fsf@oldenburg.str.redhat.com>
X-Yow: ..  If I had heart failure right now, I couldn't be a more fortunate
 man!!
Date: Tue, 16 Aug 2022 11:44:34 +0200
In-Reply-To: <87a684ejbj.fsf@oldenburg.str.redhat.com> (Florian Weimer via
 Libc-alpha's message of "Tue, 16 Aug 2022 09:30:56 +0200")
Message-ID: <mvmsflwh69p.fsf@suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Aug 2022 09:44:37 -0000

On Aug 16 2022, Florian Weimer via Libc-alpha wrote:

> The #ifdef FSOPEN_CLOEXEC check did not work because the macro
> was defined prior to its use.

This is confusing, since generally we want macros to be defined before
their use.  What's important here is that the use is about checking for
absence of the macro in the kernel header.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."