From: Andreas Schwab <schwab@suse.de>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] libio: Check remaining buffer size in _IO_wdo_write (bug 31183)
Date: Tue, 02 Jan 2024 11:10:16 +0100 [thread overview]
Message-ID: <mvmv88chwqf.fsf@suse.de> (raw)
In-Reply-To: <87bkakx3b0.fsf@oldenburg.str.redhat.com> (Florian Weimer's message of "Wed, 20 Dec 2023 17:10:43 +0100")
On Dez 20 2023, Florian Weimer wrote:
> The multibyte character needs to fit into the remaining buffer space,
> not the already-written buffer space. Without the fix, we were never
> moving the write pointer from the start of the buffer, always using
> the single-character fallback buffer.
>
> Fixes commit 04b76b5aa8b2d1d19066e42dd1 ("Don't error out writing
> a multibyte character to an unbuffered stream (bug 17522)").
Ok.
I don't know how I managed to get that so wrong.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
prev parent reply other threads:[~2024-01-02 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 16:10 Florian Weimer
2024-01-02 10:10 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmv88chwqf.fsf@suse.de \
--to=schwab@suse.de \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).