From: Andreas Schwab <schwab@suse.de>
To: Joe Simmons-Talbott <josimmon@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] nss: Get rid of alloca usage in makedb's write_output.
Date: Thu, 28 Sep 2023 13:16:00 +0200 [thread overview]
Message-ID: <mvmv8bupmz3.fsf@suse.de> (raw)
In-Reply-To: <20230926135528.3517253-1-josimmon@redhat.com> (Joe Simmons-Talbott's message of "Tue, 26 Sep 2023 09:54:48 -0400")
On Sep 26 2023, Joe Simmons-Talbott wrote:
> @@ -802,6 +812,7 @@ write_output (int fd)
> assert (iov_nelts <= INT_MAX);
> if (writev (fd, iov, iov_nelts) != keydataoffset)
> {
> + scratch_buffer_free (&sbuf);
> error (0, errno, gettext ("failed to write new database file"));
> return EXIT_FAILURE;
Does scratch_buffer_free guarantee that errno is not changed?
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2023-09-28 11:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 13:54 Joe Simmons-Talbott
2023-09-28 11:16 ` Andreas Schwab [this message]
2023-09-28 13:14 ` Joe Simmons-Talbott
2023-09-28 13:32 ` Andreas Schwab
2023-09-28 15:52 ` Gabriel Ravier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmv8bupmz3.fsf@suse.de \
--to=schwab@suse.de \
--cc=josimmon@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).