From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-73139-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 20634 invoked by alias); 8 Sep 2016 10:13:04 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 20610 invoked by uid 89); 8 Sep 2016 10:13:03 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1905
X-HELO: mx2.suse.de
From: Andreas Schwab <schwab@suse.de>
To: Florian Weimer <fweimer@redhat.com>
Cc: Rical Jasan <ricaljasan@pacific.net>,  libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] Add getrandom implementation [BZ #17252]
References: <88371300-c533-9886-f1de-e34f17f7cbb4@redhat.com>
	<5774E713.5000907@pacific.net>
	<700f4f79-2ef1-c34b-2ce9-190e5899fa64@redhat.com>
X-Yow: I'm in DISGUISE as a BAGGAGE CHECKER....I can watch the house, if it's
 ORANGE...
Date: Thu, 08 Sep 2016 10:13:00 -0000
In-Reply-To: <700f4f79-2ef1-c34b-2ce9-190e5899fa64@redhat.com> (Florian
	Weimer's message of "Thu, 8 Sep 2016 11:53:12 +0200")
Message-ID: <mvmy432em3i.fsf@hawking.suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2016-09/txt/msg00115.txt.bz2

On Sep 08 2016, Florian Weimer <fweimer@redhat.com> wrote:

> diff --git a/stdlib/tst-getrandom.c b/stdlib/tst-getrandom.c
> new file mode 100644
> index 0000000..2e4f7e7
> --- /dev/null
> +++ b/stdlib/tst-getrandom.c
> @@ -0,0 +1,162 @@
> +/* Tests for the getrandom function.
> +   Copyright (C) 2016 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <http://www.gnu.org/licenses/>.  */
> +
> +#include <errno.h>
> +#include <stdbool.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <sys/random.h>
> +
> +/* Set to true if any errors are encountered.  */
> +static bool errors;
> +
> +/* Test getrandom with a single buffer length.  */
> +static void
> +test_length (char *buffer, int length, unsigned flags)
> +{
> +  memset (buffer, 0, length);
> +  strcpy (buffer + length, "123");
> +  ssize_t ret = getrandom (buffer, length, flags);
> +  if (ret < 0)
> +    {
> +      if (!((flags & GRND_RANDOM)
> +            && (flags & GRND_NONBLOCK)

Please add != 0 (no implicit boolean coercion).

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."