From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 9EB233AA900F for ; Thu, 14 Sep 2023 06:57:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9EB233AA900F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id C6C3F21842; Thu, 14 Sep 2023 06:57:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1694674636; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CP7rBRbJSXOPFFEAx7OaKy1wcIwNpF/i0im7jO5Pfzs=; b=S7e0JgR3G7JmKduSYUhbWHjcXr8u9djuiBbYaupSjPrcP0qQyj2ZZgC1Arg0/JvWIklvho oDhEWDMqeJ9KdXEXqE0SlIOS4/YlDtfZ7i366KLPdirhs/3VIWSEr94hFijUPoXSEohHh6 m77J5AbP2BYQGfSjOMVI9pkI5SyeRV8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1694674636; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CP7rBRbJSXOPFFEAx7OaKy1wcIwNpF/i0im7jO5Pfzs=; b=Io1jpJSqIiUTY6JYRQNEv71h4E4Nkl4rSzenfEqMc0ZjvBoHbiOC3cF21EHD4Ha8W7dcMj NajIyUnk9JjK02Cw== Received: from hawking.nue2.suse.org (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id B4B3C2C142; Thu, 14 Sep 2023 06:57:16 +0000 (UTC) Received: by hawking.nue2.suse.org (Postfix, from userid 17005) id B56074A04BB; Thu, 14 Sep 2023 08:57:16 +0200 (CEST) From: Andreas Schwab To: Joe Simmons-Talbott Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v4] argp-help: Get rid of alloca. In-Reply-To: <20230913204426.1460643-1-josimmon@redhat.com> (Joe Simmons-Talbott's message of "Wed, 13 Sep 2023 16:44:09 -0400") References: <20230913204426.1460643-1-josimmon@redhat.com> X-Yow: Now I need a suntan, a tennis lesson, Annette Funicello and two dozen Day-Glo orange paper jumpsuits!! Date: Thu, 14 Sep 2023 08:57:16 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sep 13 2023, Joe Simmons-Talbott wrote: > + short_no_arg_opts = malloc (strlen (hol->short_options) + 1); > + assert (short_no_arg_opts != NULL); A library should never use assert for resource exhaustion checks. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."