From: Paul Zimmermann <Paul.Zimmermann@inria.fr>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 4/5] Remove slow paths from atan2
Date: Mon, 04 Jan 2021 17:49:13 +0100 [thread overview]
Message-ID: <mwlfd8zlyu.fsf@tomate.loria.fr> (raw)
In-Reply-To: <VE1PR08MB55995DAFEA510C9BACAF0A5283D20@VE1PR08MB5599.eurprd08.prod.outlook.com> (message from Wilco Dijkstra via Libc-alpha on Mon, 4 Jan 2021 12:21:53 +0000)
Dear Wilco,
same comments for this last patch:
- it would be nice to explain where the "Max ULP" come from, to allow
future developers to debug the code if needed
- it would be nice to have a summary with the maximal ulp error at the
top of the atan2() function (0.56 ULP if I'm correct)
and in addition:
- it remains one occurrence of "correctly rounded" at line 51
Best regards,
Paul
next prev parent reply other threads:[~2021-01-04 16:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 12:11 [PATCH 0/5] Remove remaining slow paths from math functions Wilco Dijkstra
2021-01-04 12:15 ` [PATCH 1/5] Remove slow paths from asin Wilco Dijkstra
2021-01-04 16:25 ` Paul Zimmermann
2021-01-04 17:06 ` Szabolcs Nagy
2021-01-04 17:41 ` Paul Zimmermann
2021-01-07 19:36 ` Wilco Dijkstra
2021-01-08 10:29 ` Paul Zimmermann
2021-01-07 19:23 ` [PATCH v2 1/5] Remove remaining slow paths from asin and acos Wilco Dijkstra
2021-01-04 12:17 ` [PATCH 2/5] Remove slow paths in tan Wilco Dijkstra
2021-01-04 16:36 ` Paul Zimmermann
2021-01-07 19:25 ` [PATCH v2 " Wilco Dijkstra
2021-01-04 12:19 ` [PATCH 3/5] Remove slow paths from atan Wilco Dijkstra
2021-01-04 16:43 ` Paul Zimmermann
2021-01-07 19:26 ` [PATCH v2 " Wilco Dijkstra
2021-01-04 12:21 ` [PATCH 4/5] Remove slow paths from atan2 Wilco Dijkstra
2021-01-04 16:49 ` Paul Zimmermann [this message]
2021-01-07 19:28 ` [PATCH v2 " Wilco Dijkstra
2021-01-04 12:25 ` [PATCH 5/5] Remove mpa files Wilco Dijkstra
2021-01-07 20:12 ` [PATCH v2 " Wilco Dijkstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mwlfd8zlyu.fsf@tomate.loria.fr \
--to=paul.zimmermann@inria.fr \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).