* Race condition in localedata tests?
@ 2014-11-18 16:17 H.J. Lu
2014-11-18 16:29 ` Carlos O'Donell
2014-11-18 19:45 ` Alexandre Oliva
0 siblings, 2 replies; 6+ messages in thread
From: H.J. Lu @ 2014-11-18 16:17 UTC (permalink / raw)
To: GNU C Library
Hi,
When machine is under heavy load, I saw
FAIL: localedata/bug-iconv-trans
FAIL: localedata/tst-mbswcs6
FAIL: localedata/tst-trans
FAIL: localedata/tst-wctype
FAIL: localedata/tst_mbrlen
FAIL: localedata/tst_mbrtowc
FAIL: localedata/tst_mbsrtowcs
FAIL: localedata/tst_mbstowcs
FAIL: localedata/tst_mbtowc
FAIL: localedata/tst_swscanf
FAIL: localedata/tst_wcrtomb
FAIL: localedata/tst_wcsrtombs
FAIL: localedata/tst_wcstombs
FAIL: localedata/tst_wctob
FAIL: localedata/tst_wctomb
Has anyone else seen it?
--
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Race condition in localedata tests?
2014-11-18 16:17 Race condition in localedata tests? H.J. Lu
@ 2014-11-18 16:29 ` Carlos O'Donell
2014-11-18 16:39 ` H.J. Lu
2014-11-18 19:45 ` Alexandre Oliva
1 sibling, 1 reply; 6+ messages in thread
From: Carlos O'Donell @ 2014-11-18 16:29 UTC (permalink / raw)
To: H.J. Lu, GNU C Library
On 11/18/2014 11:17 AM, H.J. Lu wrote:
> Hi,
>
> When machine is under heavy load, I saw
>
> FAIL: localedata/bug-iconv-trans
> FAIL: localedata/tst-mbswcs6
> FAIL: localedata/tst-trans
> FAIL: localedata/tst-wctype
> FAIL: localedata/tst_mbrlen
> FAIL: localedata/tst_mbrtowc
> FAIL: localedata/tst_mbsrtowcs
> FAIL: localedata/tst_mbstowcs
> FAIL: localedata/tst_mbtowc
> FAIL: localedata/tst_swscanf
> FAIL: localedata/tst_wcrtomb
> FAIL: localedata/tst_wcsrtombs
> FAIL: localedata/tst_wcstombs
> FAIL: localedata/tst_wctob
> FAIL: localedata/tst_wctomb
>
> Has anyone else seen it?
No.
Failing memory allocations?
Do the tests have explicit dependencies on the locales they use?
Perhaps it just happens that de_DE.UTF-8 hits the filesystem by
the time the test runs.
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Race condition in localedata tests?
2014-11-18 16:29 ` Carlos O'Donell
@ 2014-11-18 16:39 ` H.J. Lu
2014-11-18 16:41 ` H.J. Lu
0 siblings, 1 reply; 6+ messages in thread
From: H.J. Lu @ 2014-11-18 16:39 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: GNU C Library
On Tue, Nov 18, 2014 at 8:28 AM, Carlos O'Donell <carlos@redhat.com> wrote:
> On 11/18/2014 11:17 AM, H.J. Lu wrote:
>> Hi,
>>
>> When machine is under heavy load, I saw
>>
>> FAIL: localedata/bug-iconv-trans
>> FAIL: localedata/tst-mbswcs6
>> FAIL: localedata/tst-trans
>> FAIL: localedata/tst-wctype
>> FAIL: localedata/tst_mbrlen
>> FAIL: localedata/tst_mbrtowc
>> FAIL: localedata/tst_mbsrtowcs
>> FAIL: localedata/tst_mbstowcs
>> FAIL: localedata/tst_mbtowc
>> FAIL: localedata/tst_swscanf
>> FAIL: localedata/tst_wcrtomb
>> FAIL: localedata/tst_wcsrtombs
>> FAIL: localedata/tst_wcstombs
>> FAIL: localedata/tst_wctob
>> FAIL: localedata/tst_wctomb
>>
>> Has anyone else seen it?
>
> No.
>
> Failing memory allocations?
I have plenty of memory.
> Do the tests have explicit dependencies on the locales they use?
> Perhaps it just happens that de_DE.UTF-8 hits the filesystem by
> the time the test runs.
>
localedata/Makefile has
# Dependency for the locale files. We actually make it depend only on
# one of the files.
$(addprefix $(objpfx),$(CTYPE_FILES)): %: \
gen-locale.sh $(common-objpfx)locale/localedef Makefile \
$(addprefix charmaps/,$(CHARMAPS)) $(addprefix locales/,$(LOCALE_SRCS))
@$(SHELL) gen-locale.sh $(common-objpfx) \
'$(built-program-cmd-before-env)' '$(run-program-env)' \
'$(built-program-cmd-after-env)' $@; \
$(evaluate-test)
$(addsuffix .out,$(addprefix $(objpfx),$(tests))): %: \
$(addprefix $(objpfx),$(CTYPE_FILES))
$(objpfx)sort-test.out: sort-test.sh $(objpfx)collate-test $(objpfx)xfrm-test \
$(test-input-data) $(addprefix $(objpfx),$(CTYPE_FILES))
$(SHELL) $< $(common-objpfx) '$(test-program-prefix-before-env)' \
'$(run-program-env)' '$(test-program-prefix-after-env)' \
$(test-input) \
> $@; \
$(evaluate-test)
However, there is no $(CTYPE_FILES) dependency for those tests
above, which fail at random under heavy load with parallel build.
--
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Race condition in localedata tests?
2014-11-18 16:39 ` H.J. Lu
@ 2014-11-18 16:41 ` H.J. Lu
2014-11-18 19:47 ` Carlos O'Donell
0 siblings, 1 reply; 6+ messages in thread
From: H.J. Lu @ 2014-11-18 16:41 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: GNU C Library
On Tue, Nov 18, 2014 at 8:39 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Nov 18, 2014 at 8:28 AM, Carlos O'Donell <carlos@redhat.com> wrote:
>> On 11/18/2014 11:17 AM, H.J. Lu wrote:
>>> Hi,
>>>
>>> When machine is under heavy load, I saw
>>>
>>> FAIL: localedata/bug-iconv-trans
>>> FAIL: localedata/tst-mbswcs6
>>> FAIL: localedata/tst-trans
>>> FAIL: localedata/tst-wctype
>>> FAIL: localedata/tst_mbrlen
>>> FAIL: localedata/tst_mbrtowc
>>> FAIL: localedata/tst_mbsrtowcs
>>> FAIL: localedata/tst_mbstowcs
>>> FAIL: localedata/tst_mbtowc
>>> FAIL: localedata/tst_swscanf
>>> FAIL: localedata/tst_wcrtomb
>>> FAIL: localedata/tst_wcsrtombs
>>> FAIL: localedata/tst_wcstombs
>>> FAIL: localedata/tst_wctob
>>> FAIL: localedata/tst_wctomb
>>>
>>> Has anyone else seen it?
>>
>> No.
>>
>> Failing memory allocations?
>
> I have plenty of memory.
>
>> Do the tests have explicit dependencies on the locales they use?
>> Perhaps it just happens that de_DE.UTF-8 hits the filesystem by
>> the time the test runs.
>>
>
> localedata/Makefile has
>
> # Dependency for the locale files. We actually make it depend only on
> # one of the files.
> $(addprefix $(objpfx),$(CTYPE_FILES)): %: \
> gen-locale.sh $(common-objpfx)locale/localedef Makefile \
> $(addprefix charmaps/,$(CHARMAPS)) $(addprefix locales/,$(LOCALE_SRCS))
> @$(SHELL) gen-locale.sh $(common-objpfx) \
> '$(built-program-cmd-before-env)' '$(run-program-env)' \
> '$(built-program-cmd-after-env)' $@; \
> $(evaluate-test)
>
> $(addsuffix .out,$(addprefix $(objpfx),$(tests))): %: \
> $(addprefix $(objpfx),$(CTYPE_FILES))
>
> $(objpfx)sort-test.out: sort-test.sh $(objpfx)collate-test $(objpfx)xfrm-test \
> $(test-input-data) $(addprefix $(objpfx),$(CTYPE_FILES))
> $(SHELL) $< $(common-objpfx) '$(test-program-prefix-before-env)' \
> '$(run-program-env)' '$(test-program-prefix-after-env)' \
> $(test-input) \
> > $@; \
> $(evaluate-test)
>
> However, there is no $(CTYPE_FILES) dependency for those tests
> above, which fail at random under heavy load with parallel build.
>
>
I opened:
https://sourceware.org/bugzilla/show_bug.cgi?id=17617
--
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Race condition in localedata tests?
2014-11-18 16:17 Race condition in localedata tests? H.J. Lu
2014-11-18 16:29 ` Carlos O'Donell
@ 2014-11-18 19:45 ` Alexandre Oliva
1 sibling, 0 replies; 6+ messages in thread
From: Alexandre Oliva @ 2014-11-18 19:45 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library
On Nov 18, 2014, "H.J. Lu" <hjl.tools@gmail.com> wrote:
> When machine is under heavy load, I saw
[...]
> FAIL: localedata/tst_wctomb
> Has anyone else seen it?
Yeah, I've seen some localedata failures come and go, even without
parallel check, when the build machine was busy with other stuff. I
didn't try to track them down.
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Race condition in localedata tests?
2014-11-18 16:41 ` H.J. Lu
@ 2014-11-18 19:47 ` Carlos O'Donell
0 siblings, 0 replies; 6+ messages in thread
From: Carlos O'Donell @ 2014-11-18 19:47 UTC (permalink / raw)
To: H.J. Lu, Konstantin Serebryany; +Cc: GNU C Library
On 11/18/2014 11:41 AM, H.J. Lu wrote:
>>> Do the tests have explicit dependencies on the locales they use?
>>> Perhaps it just happens that de_DE.UTF-8 hits the filesystem by
>>> the time the test runs.
>>>
>>
>> localedata/Makefile has
>>
>> # Dependency for the locale files. We actually make it depend only on
>> # one of the files.
>> $(addprefix $(objpfx),$(CTYPE_FILES)): %: \
>> gen-locale.sh $(common-objpfx)locale/localedef Makefile \
>> $(addprefix charmaps/,$(CHARMAPS)) $(addprefix locales/,$(LOCALE_SRCS))
>> @$(SHELL) gen-locale.sh $(common-objpfx) \
>> '$(built-program-cmd-before-env)' '$(run-program-env)' \
>> '$(built-program-cmd-after-env)' $@; \
>> $(evaluate-test)
>>
>> $(addsuffix .out,$(addprefix $(objpfx),$(tests))): %: \
>> $(addprefix $(objpfx),$(CTYPE_FILES))
>>
>> $(objpfx)sort-test.out: sort-test.sh $(objpfx)collate-test $(objpfx)xfrm-test \
>> $(test-input-data) $(addprefix $(objpfx),$(CTYPE_FILES))
>> $(SHELL) $< $(common-objpfx) '$(test-program-prefix-before-env)' \
>> '$(run-program-env)' '$(test-program-prefix-after-env)' \
>> $(test-input) \
>> > $@; \
>> $(evaluate-test)
>>
>> However, there is no $(CTYPE_FILES) dependency for those tests
>> above, which fail at random under heavy load with parallel build.
>>
>>
>
> I opened:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=17617
H.J.,
Thanks. I expected this might be the case. We'd seen other issues with
high-level parallelism failing.
Kostya,
Given that you're the only other person I know who runs the glibc testsuite
at high levels of parallelism, was there anything else you saw in your testing
that fell over? I know you mentioned locales once. I know some of the tests
don't parallelize well, but that's not a failure per se.
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-11-18 19:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-18 16:17 Race condition in localedata tests? H.J. Lu
2014-11-18 16:29 ` Carlos O'Donell
2014-11-18 16:39 ` H.J. Lu
2014-11-18 16:41 ` H.J. Lu
2014-11-18 19:47 ` Carlos O'Donell
2014-11-18 19:45 ` Alexandre Oliva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).