From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by sourceware.org (Postfix) with ESMTPS id 5ED4F3858C32 for ; Wed, 10 Apr 2024 14:46:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5ED4F3858C32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=inria.fr ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5ED4F3858C32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.134.164.104 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712760372; cv=none; b=ps4qcnIgb9Wv2bPLxQXal5x70MbADN4o/N67fw80DwJi+QmDO04lA68lG26SKIL0PX4f7yz5v1Kl1S9GCD2WNb7WxsaSW0m5nt5upDNPYPTGlDGA3zRy0rLGCaTTxLsHpRTR2fZtDFn02X0VcLiCkYm9S8X2jBmN0CMHv/TZVvs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712760372; c=relaxed/simple; bh=fpdikBPPnA41KzlM32GMb5Fy8WIvo4VP3RJ4FEs6AFY=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=euLOL4aFMLFZHPKVKdlOPDhFM046vfkdV2+DV5SxA40Hy4IkpWyADs1dttsySQschr2bhVkrvk5mvRLa/ja2lJ3ZHmpbBx9owBZQKy9qYjdp0YI6szcc6waNCcW6ASNTfJFm/ukhYnMUV/uAa1pmyHhX34ew9Wgu4pRsonZcj3I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:message-id:from:to:cc:in-reply-to:subject: references; bh=+Hd4B49HRAi9QFGOA0BgcXcDMULuGsPEd9dxC+z4oxA=; b=QDP7mwSRh6TSGS+sPMSPXApJMtAQie2AeLYhe/0Y3+dnwSBBTUalw1p0 LqZMZqZCkAvTTJQerK7In9TIPDn0HWJkveeJf/URPyyyJQxGeNzM9tisL x1GR+LFYOBHEHGIEO3ykSuXmnGGGYl1XoNZhM6g8YkNKRKvE8kegSNbf6 E=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=Paul.Zimmermann@inria.fr; spf=None smtp.helo=postmaster@araignee Received-SPF: SoftFail (mail3-relais-sop.national.inria.fr: domain of Paul.Zimmermann@inria.fr is inclined to not designate 152.81.2.78 as permitted sender) identity=mailfrom; client-ip=152.81.2.78; receiver=mail3-relais-sop.national.inria.fr; envelope-from="Paul.Zimmermann@inria.fr"; x-sender="Paul.Zimmermann@inria.fr"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 include:mailout.safebrands.com a:basic-mail.safebrands.com a:basic-mail01.safebrands.com a:basic-mail02.safebrands.com ip4:128.93.142.0/24 ip4:192.134.164.0/24 ip4:128.93.162.160 ip4:89.107.174.7 mx ~all" Received-SPF: None (mail3-relais-sop.national.inria.fr: no sender authenticity information available from domain of postmaster@araignee) identity=helo; client-ip=152.81.2.78; receiver=mail3-relais-sop.national.inria.fr; envelope-from="Paul.Zimmermann@inria.fr"; x-sender="postmaster@araignee"; x-conformance=spf_only X-IronPort-AV: E=Sophos;i="6.07,190,1708383600"; d="scan'208";a="84386111" Received: from araignee.loria.fr (HELO araignee) ([152.81.2.78]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 16:46:08 +0200 Date: Wed, 10 Apr 2024 16:46:08 +0200 Message-Id: From: Paul Zimmermann To: Joseph Myers Cc: libc-alpha@sourceware.org In-Reply-To: (message from Joseph Myers on Wed, 10 Apr 2024 14:34:09 +0000 (UTC)) Subject: Re: Implement C23 log2p1 References: <41a4a6c9-4942-a9be-9459-1aaeb44ffee8@redhat.com> X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Joseph, I would prefer that you submit a v2 including the inputs yielding larger errors that I pointed out in my review. Paul > Date: Wed, 10 Apr 2024 14:34:09 +0000 (UTC) > From: Joseph Myers > cc: libc-alpha@sourceware.org > > On Wed, 10 Apr 2024, Paul Zimmermann wrote: > > > Dear Joseph, > > > > I tried your patch on a x86_64, it applies cleanly, everything compiles > > cleanly, and I can use the new log2p1 function in both binary32, binary64, > > double-extended and binary128. > > > > As for accuracy, here are the largest errors I found for rounding to nearest: > > In general I encourage adding extra tests to auto-libm-test-in where they > show errors, for any implementation in glibc, larger than those inputs > already present (but not so large that they cannot be entered in > libm-test-ulps files). So adding such inputs for log2p1 would be > appropriate after this patch is in, and the same applies for all the other > C23 functions as they get added. > > -- > Joseph S. Myers > josmyers@redhat.com > >