public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Mike FABIAN <mfabian@redhat.com>
To: Ilyahoo Proshel <ip@ipshel.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Add rif_MA locale [BZ #27781]
Date: Wed, 06 Apr 2022 12:53:25 +0200	[thread overview]
Message-ID: <s9dwng2wkii.fsf@taka.site> (raw)
In-Reply-To: <20220125172555.2527278-1-ip@ipshel.com> (Ilyahoo Proshel's message of "Tue, 25 Jan 2022 18:25:55 +0100")

Ilyahoo Proshel <ip@ipshel.com> さんはかきました:

> ---
>  locale/iso-639.def         |   1 +
>  localedata/Makefile        |   2 +
>  localedata/SUPPORTED       |   2 +
>  localedata/locales/rif_MA  | 161 +++++++++++++++++++++++++++++++++++++
>  localedata/rif_MA.UTF-8.in |  17 ++++
>  5 files changed, 183 insertions(+)
>  create mode 100644 localedata/locales/rif_MA
>  create mode 100644 localedata/rif_MA.UTF-8.in

Hi Ilyahoo,

this looks mostly good to me.

I made a small change to use ASCII in the data where possible instead of
the hard to read <U....> code point notation.

See the new attachement to

https://sourceware.org/bugzilla/show_bug.cgi?id=27781
https://sourceware.org/bugzilla/attachment.cgi?id=14051

And I added the language name:

lang_name    "Tmazi<U0263>t"

https://sourceware.org/bugzilla/show_bug.cgi?id=27781#c7

Can you please have a look whether this is OK?

-- 
Mike FABIAN <mfabian@redhat.com>
睡眠不足はいい仕事の敵だ。


  reply	other threads:[~2022-04-06 10:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 17:25 Ilyahoo Proshel
2022-04-06 10:53 ` Mike FABIAN [this message]
2022-04-07 13:01 ` Mike FABIAN
2022-04-07 13:38 ` Mike FABIAN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s9dwng2wkii.fsf@taka.site \
    --to=mfabian@redhat.com \
    --cc=ip@ipshel.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).