public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Yangyu Chen <cyy@cyyself.name>
To: Florian Weimer <fweimer@redhat.com>
Cc: Kito Cheng <kito.cheng@sifive.com>,
	Palmer Dabbelt <palmer@rivosinc.com>,
	libc-alpha@sourceware.org, vincent.chen@sifive.com,
	schwab@suse.de
Subject: Re: [PATCH v2] RISC-V: Fix IFUNC resolver cannot access gp pointer
Date: Thu, 31 Oct 2024 18:35:09 +0800	[thread overview]
Message-ID: <tencent_ED437E1A7DF8A605EFB4951CDB70C763DC09@qq.com> (raw)
In-Reply-To: <87ikt8bm1n.fsf@oldenburg.str.redhat.com>



> On Oct 31, 2024, at 18:32, Florian Weimer <fweimer@redhat.com> wrote:
> 
> * Yangyu Chen:
> 
>> I proposed an idea to bypass the GP initialization by restricting
>> the use of the norelax attribute for all callees of IFUNC. In this
>> case, the linker will retain auipc + load/store instructions to
>> access global variables based on pc-relative address mode instead
>> of relaxing them to a single load/store at a +- 2KB offset from the
>> GP.
> 
> What do you mean by “all callees of IFUNC”?  This issue only affects the
> resolver, not the IFUNC implementation itself.

Oh… I mean the IFUNC resolver generated by compilers for target_clones
feature, which is under the control of the compiler.

> 
> As I said, if the glibc dynamic linker has a reliable way to identify
> the expected GP value, it can set GP before calling the resolver.  That
> requires some form of ABI change, but it would be backwards compatible.
> (We just won't be able to do it if the binary doesn't contain the required
> information, and the __global_pointer$ dynamic symbol is absent as
> well.)
> 
> The technical side should be easy to implement.
> 
> Thanks,
> Florian


  reply	other threads:[~2024-10-31 10:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 17:01 Yangyu Chen
2024-10-30  2:58 ` Yangyu Chen
2024-10-30  3:10   ` Palmer Dabbelt
2024-10-30  6:50     ` Yangyu Chen
2024-10-30  7:36       ` Kito Cheng
2024-10-30  9:22         ` Florian Weimer
2024-10-30 10:26           ` Kito Cheng
2024-10-30 10:42             ` Florian Weimer
2024-10-30 10:48               ` Kito Cheng
2024-10-30 11:09                 ` Florian Weimer
2024-10-30 18:28                   ` Yangyu Chen
2024-10-31 10:07                     ` Kito Cheng
2024-10-31 10:32                     ` Florian Weimer
2024-10-31 10:35                       ` Yangyu Chen [this message]
2024-10-31 10:51                         ` Florian Weimer
2024-11-13 10:29     ` Yangyu Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_ED437E1A7DF8A605EFB4951CDB70C763DC09@qq.com \
    --to=cyy@cyyself.name \
    --cc=fweimer@redhat.com \
    --cc=kito.cheng@sifive.com \
    --cc=libc-alpha@sourceware.org \
    --cc=palmer@rivosinc.com \
    --cc=schwab@suse.de \
    --cc=vincent.chen@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).