* [PATCH] Remove do_set_mallopt_check prototype
@ 2019-04-23 19:43 H.J. Lu
2019-04-23 19:50 ` Carlos O'Donell
2019-04-23 21:57 ` DJ Delorie
0 siblings, 2 replies; 3+ messages in thread
From: H.J. Lu @ 2019-04-23 19:43 UTC (permalink / raw)
To: libc-alpha
Remove do_set_mallopt_check prototype since it is unused.
* malloc/arena.c (do_set_mallopt_check): Removed.
---
malloc/arena.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/malloc/arena.c b/malloc/arena.c
index 10a77b0232..8340b20b56 100644
--- a/malloc/arena.c
+++ b/malloc/arena.c
@@ -207,7 +207,6 @@ __malloc_fork_unlock_child (void)
}
#if HAVE_TUNABLES
-static inline int do_set_mallopt_check (int32_t value);
void
TUNABLE_CALLBACK (set_mallopt_check) (tunable_val_t *valp)
{
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove do_set_mallopt_check prototype
2019-04-23 19:43 [PATCH] Remove do_set_mallopt_check prototype H.J. Lu
@ 2019-04-23 19:50 ` Carlos O'Donell
2019-04-23 21:57 ` DJ Delorie
1 sibling, 0 replies; 3+ messages in thread
From: Carlos O'Donell @ 2019-04-23 19:50 UTC (permalink / raw)
To: H.J. Lu, libc-alpha
On 4/23/19 3:39 PM, H.J. Lu wrote:
> Remove do_set_mallopt_check prototype since it is unused.
>
> * malloc/arena.c (do_set_mallopt_check): Removed.
> ---
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> malloc/arena.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/malloc/arena.c b/malloc/arena.c
> index 10a77b0232..8340b20b56 100644
> --- a/malloc/arena.c
> +++ b/malloc/arena.c
> @@ -207,7 +207,6 @@ __malloc_fork_unlock_child (void)
> }
>
> #if HAVE_TUNABLES
> -static inline int do_set_mallopt_check (int32_t value);
OK. malloc/malloc.c has the function and uses it there, but we
don't use it here anymore.
> void
> TUNABLE_CALLBACK (set_mallopt_check) (tunable_val_t *valp)
> {
>
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove do_set_mallopt_check prototype
2019-04-23 19:43 [PATCH] Remove do_set_mallopt_check prototype H.J. Lu
2019-04-23 19:50 ` Carlos O'Donell
@ 2019-04-23 21:57 ` DJ Delorie
1 sibling, 0 replies; 3+ messages in thread
From: DJ Delorie @ 2019-04-23 21:57 UTC (permalink / raw)
To: H.J. Lu; +Cc: libc-alpha
"H.J. Lu" <hjl.tools@gmail.com> writes:
> * malloc/arena.c (do_set_mallopt_check): Removed.
LGTM too
Reviewed-by: DJ Delorie <dj@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-23 19:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-23 19:43 [PATCH] Remove do_set_mallopt_check prototype H.J. Lu
2019-04-23 19:50 ` Carlos O'Donell
2019-04-23 21:57 ` DJ Delorie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).