From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 427A43858C35 for ; Mon, 13 Nov 2023 20:26:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 427A43858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 427A43858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699907179; cv=none; b=IgZe1eWxFrmYdu7Gs9nhizeZOLyxoWUMXqDcI65ywmDBL04RIIFzGEZ93F0JaZiglJqnvG0rFOyYNqFQfTzJa9emfZIlM2RqEda9wO9WQUiLQ3u9wm09nS1N17pzbn43ZyQqAx3yRLWDJ8z1+BWaC2b+2x3snku/GpDQvIcy3u4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699907179; c=relaxed/simple; bh=/Xy+o3DTuuiCa8678hCPMWlsT3/CXH1ePuyhnpifrnw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=YrkEj0fByOCoS1RbmLGlwkuRIM9waB0AVQWONxh0s4pQLH2C9CST24bqMX1FdaPhN3mKt9VA4iPXb42rNtr22G7S5uAcuVig9bhJoXuI12R+o+CTZd38IVVSBVOaod5hwtqfCwwPm6NZuBBSKWEqVFw74bigpTnuOD5ga0Nik/8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699907177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=HA2ZURPBx0b61f48Pf6bJyFdknvxo4C9l1dxb7KmI9U=; b=RE+RNH/5yNDP8zecppeKAW/XCe3DLGZorJGDEjZrN3cLpM9j7mmZQMp+77B/WH+M1qpJYQ Dm9n+nOcC0HKWZiOFHIJz/IuIPjkaQ+wQrxrc8dWYeMweaEDwVpa2siaYTRx0zjkLVQ6Vf Nt8mkhZkRmNOw6qLnS4VPgdWW+6Dk58= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-7cVK64ZSPDSIdydry-E6QQ-1; Mon, 13 Nov 2023 15:26:14 -0500 X-MC-Unique: 7cVK64ZSPDSIdydry-E6QQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C90DE3806620; Mon, 13 Nov 2023 20:26:13 +0000 (UTC) Received: from greed.delorie.com (unknown [10.22.9.187]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7C1381121306; Mon, 13 Nov 2023 20:26:13 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 3ADKPOLw371745; Mon, 13 Nov 2023 15:25:54 -0500 From: DJ Delorie To: "=?ISO-8859-2?Q?Niklas_Hamb=FCchen?=" Cc: libc-alpha@sourceware.org, schwab@linux-m68k.org Subject: Re: [PATCH v2] malloc_stats(): Fix `unsigned int` overflow In-Reply-To: Date: Mon, 13 Nov 2023 15:25:20 -0500 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Niklas Hambchen writes: > @@ -5374,7 +5374,7 @@ __malloc_stats (void) > { > int i; > mstate ar_ptr; > - unsigned int in_use_b = mp_.mmapped_mem, system_b = in_use_b; > + size_t in_use_b = mp_.mmapped_mem, system_b = in_use_b; Ok. > @@ -5389,8 +5389,8 @@ __malloc_stats (void) > __libc_lock_lock (ar_ptr->mutex); > int_mallinfo (ar_ptr, &mi); > fprintf (stderr, "Arena %d:\n", i); > - fprintf (stderr, "system bytes = %10u\n", (unsigned int) mi.arena); > - fprintf (stderr, "in use bytes = %10u\n", (unsigned int) mi.uordblks); > + fprintf (stderr, "system bytes = %10zu\n", mi.arena); > + fprintf (stderr, "in use bytes = %10zu\n", mi.uordblks); Ok. > - fprintf (stderr, "system bytes = %10u\n", system_b); > - fprintf (stderr, "in use bytes = %10u\n", in_use_b); > - fprintf (stderr, "max mmap bytes = %10lu\n", > - (unsigned long) mp_.max_mmapped_mem); > + fprintf (stderr, "system bytes = %10zu\n", system_b); > + fprintf (stderr, "in use bytes = %10zu\n", in_use_b); > + fprintf (stderr, "max mmap bytes = %10zu\n", mp_.max_mmapped_mem); This needs a cast to (size_t) as max_mmapped_mem is INTERNAL_SIZE_T, which may be smaller than size_t. > - fprintf (stderr, "max mmap regions = %10u\n", (unsigned int) mp_.max_n_mmaps); > + fprintf (stderr, "max mmap regions = %10d\n", mp_.max_n_mmaps); This causes a negative number to be printed when max_n_mmaps increments past 2^31, where using "u" defers bad results until 2^32. So IMHO this one is a regression, not a fix.