From: DJ Delorie <dj@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, siddhesh@sourceware.org,
nmanthey@conp-solutions.com, guillaume@morinfr.org
Subject: Re: [PATCH v5 4/7] malloc: Add Huge Page support for mmap()
Date: Wed, 15 Dec 2021 12:43:55 -0500 [thread overview]
Message-ID: <xn35mtahlw.fsf@greed.delorie.com> (raw)
In-Reply-To: <d26240b6-76c2-6be7-d677-192c2328df4c@linaro.org>
Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
>>> + buf[r - 1] = '\0';
>>
>> This always overwrites the last byte of the file, shouldn't this be
>> buf[r] ?
>
> Yes, I have fixed it.
>
> Is this patch ok with the above fix?
Yes.
Reviewed-by: DJ Delorie <dj@redhat.com>
next prev parent reply other threads:[~2021-12-15 17:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 18:57 [PATCH v5 0/7] malloc: Improve Huge Page support Adhemerval Zanella
2021-12-14 18:58 ` [PATCH v5 1/7] malloc: Add madvise support for Transparent Huge Pages Adhemerval Zanella
2021-12-15 3:06 ` DJ Delorie
2021-12-15 12:12 ` Adhemerval Zanella
2021-12-14 18:58 ` [PATCH v5 2/7] malloc: Add THP/madvise support for sbrk Adhemerval Zanella
2021-12-15 3:28 ` DJ Delorie
2021-12-14 18:58 ` [PATCH v5 3/7] malloc: Move mmap logic to its own function Adhemerval Zanella
2021-12-15 3:30 ` DJ Delorie
2021-12-14 18:58 ` [PATCH v5 4/7] malloc: Add Huge Page support for mmap() Adhemerval Zanella
2021-12-15 4:26 ` DJ Delorie
2021-12-15 13:08 ` Adhemerval Zanella
2021-12-15 17:43 ` DJ Delorie [this message]
2021-12-14 18:58 ` [PATCH v5 5/7] malloc: Add huge page support to arenas Adhemerval Zanella
2021-12-15 4:51 ` DJ Delorie
2021-12-15 15:06 ` Adhemerval Zanella
2021-12-14 18:58 ` [PATCH v5 6/7] malloc: Move MORECORE fallback mmap to sysmalloc_mmap_fallback Adhemerval Zanella
2021-12-15 4:55 ` DJ Delorie
2021-12-14 18:58 ` [PATCH v5 7/7] malloc: Enable huge page support on main arena Adhemerval Zanella
2021-12-15 4:59 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xn35mtahlw.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=guillaume@morinfr.org \
--cc=libc-alpha@sourceware.org \
--cc=nmanthey@conp-solutions.com \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).