From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 13B9C3950C77 for ; Tue, 13 Apr 2021 21:32:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 13B9C3950C77 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-309-Jo1iHatqOROqWB60Unu_NA-1; Tue, 13 Apr 2021 17:32:33 -0400 X-MC-Unique: Jo1iHatqOROqWB60Unu_NA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DE43864083; Tue, 13 Apr 2021 21:32:31 +0000 (UTC) Received: from rhel8.vm.delorie.com (ovpn-112-40.rdu2.redhat.com [10.10.112.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4E6D1A353; Tue, 13 Apr 2021 21:32:31 +0000 (UTC) Received: from rhel8.vm.redhat.com (localhost [127.0.0.1]) by rhel8.vm.delorie.com (8.15.2/8.15.2) with ESMTP id 13DLWUQO390829; Tue, 13 Apr 2021 17:32:30 -0400 From: DJ Delorie To: Szabolcs Nagy Cc: libc-alpha@sourceware.org, Richard.Earnshaw@arm.com Subject: Re: [PATCH 02/16] Remove PR_TAGGED_ADDR_ENABLE from sys/prctl.h In-Reply-To: <20210413083736.GT23289@arm.com> (message from Szabolcs Nagy on Tue, 13 Apr 2021 09:37:37 +0100) Date: Tue, 13 Apr 2021 17:32:30 -0400 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 21:32:36 -0000 Szabolcs Nagy writes: > DJ: can you please do the review of this header change? > (others seems to be less interested looking at it) >> > -#ifndef PR_TAGGED_ADDR_ENABLE >> > -# define PR_TAGGED_ADDR_ENABLE (1UL << 8) >> > -#endif >> > - I confirmed that 5.4 and master define this as 1UL << 0 so yeah, this needs to go. LGTM. Reviewed-by: DJ Delorie