From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id C9460386100F for ; Tue, 16 Feb 2021 05:16:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C9460386100F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-esIYGcOLNIWfEak6ikwGYQ-1; Tue, 16 Feb 2021 00:16:01 -0500 X-MC-Unique: esIYGcOLNIWfEak6ikwGYQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EA583C283; Tue, 16 Feb 2021 05:16:00 +0000 (UTC) Received: from greed.delorie.com (ovpn-114-77.rdu2.redhat.com [10.10.114.77]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B5B9A5B698; Tue, 16 Feb 2021 05:16:00 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.14.7/8.14.7) with ESMTP id 11G5Fw4J015661; Tue, 16 Feb 2021 00:15:58 -0500 From: DJ Delorie To: Lukasz Majewski Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 1/3] tst: Extend cross-test-ssh.sh to specify if target date can be altered In-Reply-To: <20210210103710.1325-1-lukma@denx.de> (message from Lukasz Majewski on Wed, 10 Feb 2021 11:37:08 +0100) Date: Tue, 16 Feb 2021 00:15:58 -0500 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2021 05:16:06 -0000 Lukasz Majewski writes: > +The @code{GLIBC_TEST_ALLOW_TIME_SETTING} is set in the environment in "The FOO is set" reads clumsy. How about just "FOO is set" ? It's OK to start a sentence with a @code{}. (In general, you should say "The FOO environment variable" or just "FOO" but not "The FOO") > In this case there is no prevention from running those tests in > parallel, "In this case nothing prevents those tests from running in parallel," > so the caller shall assure that those tests > +are serialized or provide proper wrapper script for it. "provide a proper" (add "a") > +The @code{cross-test-ssh.sh} script is used and one passes > +@option{--allow-time-setting} flag. "One passes the @option{}" (add "the") > In this case both - setting the The "-" is not needed here. Drop the "the" > +usage="usage: ${progname} [--ssh SSH][--allow-time-setting] HOST COMMAND ..." Space between "][" > +If the '--allow-time-setting' flag is present, set > +GLIBC_TEST_ALLOW_TIME_SETTING on the remote machine to inform that s/inform/indicate/ perhaps ? > +FLOCK_PATH="/var/lock/clock_settime" Should we forcibly set this, or allow the user to override it in case /var/lock is the wrong directory to use? I.e. FLOCK_PATH="${FLOCK_PATH:-/var/lock/clock_settime}" > +if [ "$settimeallowed" ]; then For paranoia, this should be something like if [ x"$settimeallowed" != x"" ]; then > + exec 99<>${FLOCK_PATH} Check for error > + command="export GLIBC_TEST_ALLOW_TIME_SETTING=1 ${command}" This needs the space before ${command} to be a newline, see the addition of TIMEOUTFACTOR for an example. This causes the exports and the ${command} to be separate command lines on the target.