public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: DJ Delorie <dj@redhat.com>
To: Alejandro Colomar <alx@kernel.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] malloc.c: Remove bogus __nonnull attribute
Date: Tue, 11 Jul 2023 12:55:18 -0400	[thread overview]
Message-ID: <xn4jmacrrd.fsf@greed.delorie.com> (raw)
In-Reply-To: <20230711135923.38979-1-alx@kernel.org> (message from Alejandro Colomar via Libc-alpha on Tue, 11 Jul 2023 15:59:24 +0200)

Alejandro Colomar via Libc-alpha <libc-alpha@sourceware.org> writes:
> This function doesn't accept pointers.

Does __nonnull() tell the compiler anything about not-pointers that
can't be zero?  Asking for a friend... ;-)

LGTM
Reviewed-by: DJ Delorie <dj@redhat.com>

> -checked_request2size (size_t req) __nonnull (1)
> +checked_request2size (size_t req)


  reply	other threads:[~2023-07-11 16:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-11 13:59 Alejandro Colomar
2023-07-11 16:55 ` DJ Delorie [this message]
2023-07-11 23:07   ` Alejandro Colomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xn4jmacrrd.fsf@greed.delorie.com \
    --to=dj@redhat.com \
    --cc=alx@kernel.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).